Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Remove all uses of field-tracking flags that do not make decisions but are subject to existing information. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19650

Patch Set 1 #

Patch Set 2 : More flag removal #

Patch Set 3 : More flags #

Patch Set 4 : More flags removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -162 lines) Patch
M src/a64/full-codegen-a64.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M src/a64/lithium-a64.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/a64/stub-cache-a64.cc View 1 7 chunks +15 lines, -15 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 7 chunks +15 lines, -15 lines 0 comments Download
M src/code-stubs.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 5 chunks +6 lines, -9 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 8 chunks +16 lines, -16 lines 0 comments Download
M src/ic.cc View 1 2 3 1 chunk +6 lines, -8 lines 0 comments Download
M src/json-parser.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 5 chunks +12 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 2 3 5 chunks +7 lines, -22 lines 0 comments Download
M src/runtime.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 7 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-20 16:24:14 UTC) #1
Igor Sheludko
lgtm with a nit: I think you can also remove FLAG_track_double_fields usages from FullCodeGenerator::VisitObjectLiteral() (all ...
6 years, 10 months ago (2014-02-25 16:30:55 UTC) #2
Toon Verwaest
6 years, 9 months ago (2014-03-04 12:48:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r19650 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698