Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3867 matching lines...) Expand 10 before | Expand all | Expand 10 after
3878 __ Store(MemOperand(object, offset), value, representation); 3878 __ Store(MemOperand(object, offset), value, representation);
3879 } 3879 }
3880 return; 3880 return;
3881 } 3881 }
3882 3882
3883 Register object = ToRegister(instr->object()); 3883 Register object = ToRegister(instr->object());
3884 Handle<Map> transition = instr->transition(); 3884 Handle<Map> transition = instr->transition();
3885 SmiCheck check_needed = hinstr->value()->IsHeapObject() 3885 SmiCheck check_needed = hinstr->value()->IsHeapObject()
3886 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 3886 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
3887 3887
3888 if (FLAG_track_fields && representation.IsSmi()) { 3888 if (representation.IsSmi()) {
3889 if (instr->value()->IsConstantOperand()) { 3889 if (instr->value()->IsConstantOperand()) {
3890 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); 3890 LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
3891 if (!IsInteger32Constant(operand_value) && 3891 if (!IsInteger32Constant(operand_value) &&
3892 !IsSmiConstant(operand_value)) { 3892 !IsSmiConstant(operand_value)) {
3893 DeoptimizeIf(no_condition, instr->environment()); 3893 DeoptimizeIf(no_condition, instr->environment());
3894 } 3894 }
3895 } 3895 }
3896 } else if (FLAG_track_heap_object_fields && representation.IsHeapObject()) { 3896 } else if (representation.IsHeapObject()) {
3897 if (instr->value()->IsConstantOperand()) { 3897 if (instr->value()->IsConstantOperand()) {
3898 LConstantOperand* operand_value = LConstantOperand::cast(instr->value()); 3898 LConstantOperand* operand_value = LConstantOperand::cast(instr->value());
3899 if (IsInteger32Constant(operand_value)) { 3899 if (IsInteger32Constant(operand_value)) {
3900 DeoptimizeIf(no_condition, instr->environment()); 3900 DeoptimizeIf(no_condition, instr->environment());
3901 } 3901 }
3902 } else { 3902 } else {
3903 if (!hinstr->value()->type().IsHeapObject()) { 3903 if (!hinstr->value()->type().IsHeapObject()) {
3904 Register value = ToRegister(instr->value()); 3904 Register value = ToRegister(instr->value());
3905 Condition cc = masm()->CheckSmi(value); 3905 Condition cc = masm()->CheckSmi(value);
3906 DeoptimizeIf(cc, instr->environment()); 3906 DeoptimizeIf(cc, instr->environment());
(...skipping 1671 matching lines...) Expand 10 before | Expand all | Expand 10 after
5578 FixedArray::kHeaderSize - kPointerSize)); 5578 FixedArray::kHeaderSize - kPointerSize));
5579 __ bind(&done); 5579 __ bind(&done);
5580 } 5580 }
5581 5581
5582 5582
5583 #undef __ 5583 #undef __
5584 5584
5585 } } // namespace v8::internal 5585 } } // namespace v8::internal
5586 5586
5587 #endif // V8_TARGET_ARCH_X64 5587 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698