Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/stub-cache-a64.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1634 matching lines...) Expand 10 before | Expand all | Expand 10 after
1645 __ mov(r2, Operand(Smi::FromInt(expr->literal_index()))); 1645 __ mov(r2, Operand(Smi::FromInt(expr->literal_index())));
1646 __ mov(r1, Operand(constant_properties)); 1646 __ mov(r1, Operand(constant_properties));
1647 int flags = expr->fast_elements() 1647 int flags = expr->fast_elements()
1648 ? ObjectLiteral::kFastElements 1648 ? ObjectLiteral::kFastElements
1649 : ObjectLiteral::kNoFlags; 1649 : ObjectLiteral::kNoFlags;
1650 flags |= expr->has_function() 1650 flags |= expr->has_function()
1651 ? ObjectLiteral::kHasFunction 1651 ? ObjectLiteral::kHasFunction
1652 : ObjectLiteral::kNoFlags; 1652 : ObjectLiteral::kNoFlags;
1653 __ mov(r0, Operand(Smi::FromInt(flags))); 1653 __ mov(r0, Operand(Smi::FromInt(flags)));
1654 int properties_count = constant_properties->length() / 2; 1654 int properties_count = constant_properties->length() / 2;
1655 if ((FLAG_track_double_fields && expr->may_store_doubles()) || 1655 if (expr->may_store_doubles() || expr->depth() > 1 || Serializer::enabled() ||
1656 expr->depth() > 1 || Serializer::enabled() ||
1657 flags != ObjectLiteral::kFastElements || 1656 flags != ObjectLiteral::kFastElements ||
1658 properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) { 1657 properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) {
1659 __ Push(r3, r2, r1, r0); 1658 __ Push(r3, r2, r1, r0);
1660 __ CallRuntime(Runtime::kCreateObjectLiteral, 4); 1659 __ CallRuntime(Runtime::kCreateObjectLiteral, 4);
1661 } else { 1660 } else {
1662 FastCloneShallowObjectStub stub(properties_count); 1661 FastCloneShallowObjectStub stub(properties_count);
1663 __ CallStub(&stub); 1662 __ CallStub(&stub);
1664 } 1663 }
1665 1664
1666 // If result_saved is true the result is on top of the stack. If 1665 // If result_saved is true the result is on top of the stack. If
(...skipping 3251 matching lines...) Expand 10 before | Expand all | Expand 10 after
4918 ASSERT(Memory::uint32_at(interrupt_address_pointer) == 4917 ASSERT(Memory::uint32_at(interrupt_address_pointer) ==
4919 reinterpret_cast<uint32_t>( 4918 reinterpret_cast<uint32_t>(
4920 isolate->builtins()->OsrAfterStackCheck()->entry())); 4919 isolate->builtins()->OsrAfterStackCheck()->entry()));
4921 return OSR_AFTER_STACK_CHECK; 4920 return OSR_AFTER_STACK_CHECK;
4922 } 4921 }
4923 4922
4924 4923
4925 } } // namespace v8::internal 4924 } } // namespace v8::internal
4926 4925
4927 #endif // V8_TARGET_ARCH_ARM 4926 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/a64/stub-cache-a64.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698