Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: src/a64/lithium-codegen-a64.cc

Issue 173963002: Remove all uses of field-tracking flags that do not make decisions but are subject to existing info… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More flags removed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/lithium-a64.cc ('k') | src/a64/stub-cache-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5011 matching lines...) Expand 10 before | Expand all | Expand 10 after
5022 Register value = ToRegister(instr->value()); 5022 Register value = ToRegister(instr->value());
5023 __ Store(value, MemOperand(object, offset), representation); 5023 __ Store(value, MemOperand(object, offset), representation);
5024 return; 5024 return;
5025 } 5025 }
5026 5026
5027 Handle<Map> transition = instr->transition(); 5027 Handle<Map> transition = instr->transition();
5028 SmiCheck check_needed = 5028 SmiCheck check_needed =
5029 instr->hydrogen()->value()->IsHeapObject() 5029 instr->hydrogen()->value()->IsHeapObject()
5030 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 5030 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
5031 5031
5032 if (FLAG_track_heap_object_fields && representation.IsHeapObject()) { 5032 if (representation.IsHeapObject()) {
5033 Register value = ToRegister(instr->value()); 5033 Register value = ToRegister(instr->value());
5034 if (!instr->hydrogen()->value()->type().IsHeapObject()) { 5034 if (!instr->hydrogen()->value()->type().IsHeapObject()) {
5035 DeoptimizeIfSmi(value, instr->environment()); 5035 DeoptimizeIfSmi(value, instr->environment());
5036 5036
5037 // We know that value is a smi now, so we can omit the check below. 5037 // We know that value is a smi now, so we can omit the check below.
5038 check_needed = OMIT_SMI_CHECK; 5038 check_needed = OMIT_SMI_CHECK;
5039 } 5039 }
5040 } else if (representation.IsDouble()) { 5040 } else if (representation.IsDouble()) {
5041 ASSERT(transition.is_null()); 5041 ASSERT(transition.is_null());
5042 ASSERT(access.IsInobject()); 5042 ASSERT(access.IsInobject());
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
5662 __ Bind(&out_of_object); 5662 __ Bind(&out_of_object);
5663 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5663 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5664 // Index is equal to negated out of object property index plus 1. 5664 // Index is equal to negated out of object property index plus 1.
5665 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5665 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5666 __ Ldr(result, FieldMemOperand(result, 5666 __ Ldr(result, FieldMemOperand(result,
5667 FixedArray::kHeaderSize - kPointerSize)); 5667 FixedArray::kHeaderSize - kPointerSize));
5668 __ Bind(&done); 5668 __ Bind(&done);
5669 } 5669 }
5670 5670
5671 } } // namespace v8::internal 5671 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/a64/lithium-a64.cc ('k') | src/a64/stub-cache-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698