Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: extensions/browser/lazy_background_task_queue_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/lazy_background_task_queue_unittest.cc
diff --git a/extensions/browser/lazy_background_task_queue_unittest.cc b/extensions/browser/lazy_background_task_queue_unittest.cc
index a2b82eb2cca9e30e97ff77551b79122d43148f4a..02ec3bbedd3b7f8d809ebc0986017809d20fafdb 100644
--- a/extensions/browser/lazy_background_task_queue_unittest.cc
+++ b/extensions/browser/lazy_background_task_queue_unittest.cc
@@ -82,10 +82,11 @@ class LazyBackgroundTaskQueueTest : public ExtensionsTest {
scoped_refptr<Extension> CreateSimpleExtension() {
scoped_refptr<Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "No background")
- .Set("version", "1")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "No background")
+ .Set("version", "1")
+ .Set("manifest_version", 2)
+ .Build())
.SetID("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
.Build();
ExtensionRegistry::Get(browser_context())->AddEnabled(extension);
@@ -96,15 +97,16 @@ class LazyBackgroundTaskQueueTest : public ExtensionsTest {
scoped_refptr<Extension> CreateLazyBackgroundExtension() {
scoped_refptr<Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
DictionaryBuilder()
.Set("name", "Lazy background")
.Set("version", "1")
.Set("manifest_version", 2)
- .Set("background",
- std::move(DictionaryBuilder()
- .Set("page", "background.html")
- .SetBoolean("persistent", false)))))
+ .Set("background", DictionaryBuilder()
+ .Set("page", "background.html")
+ .SetBoolean("persistent", false)
+ .Build())
+ .Build())
.SetID("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb")
.Build();
ExtensionRegistry::Get(browser_context())->AddEnabled(extension);

Powered by Google App Engine
This is Rietveld 408576698