Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: extensions/browser/mojo/keep_alive_impl_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/mojo/keep_alive_impl_unittest.cc
diff --git a/extensions/browser/mojo/keep_alive_impl_unittest.cc b/extensions/browser/mojo/keep_alive_impl_unittest.cc
index c1f48109bda85657737bca802e65e4d21626e688..5d640e055d303d753b9a80931c0b8f94f419e888 100644
--- a/extensions/browser/mojo/keep_alive_impl_unittest.cc
+++ b/extensions/browser/mojo/keep_alive_impl_unittest.cc
@@ -28,17 +28,21 @@ class KeepAliveTest : public ExtensionsTest {
message_loop_.reset(new base::MessageLoop);
extension_ =
ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
DictionaryBuilder()
.Set("name", "app")
.Set("version", "1")
.Set("manifest_version", 2)
- .Set("app",
- std::move(DictionaryBuilder().Set(
- "background",
- std::move(DictionaryBuilder().Set(
- "scripts", std::move(ListBuilder().Append(
- "background.js")))))))))
+ .Set("app", DictionaryBuilder()
+ .Set("background",
+ DictionaryBuilder()
+ .Set("scripts",
+ ListBuilder()
+ .Append("background.js")
+ .Build())
+ .Build())
+ .Build())
+ .Build())
.SetID("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
.Build();
}
@@ -110,16 +114,21 @@ TEST_F(KeepAliveTest, UnloadExtension) {
scoped_refptr<const Extension> other_extension =
ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
DictionaryBuilder()
.Set("name", "app")
.Set("version", "1")
.Set("manifest_version", 2)
- .Set("app", std::move(DictionaryBuilder().Set(
- "background",
- std::move(DictionaryBuilder().Set(
- "scripts", std::move(ListBuilder().Append(
- "background.js")))))))))
+ .Set("app",
+ DictionaryBuilder()
+ .Set("background",
+ DictionaryBuilder()
+ .Set("scripts", ListBuilder()
+ .Append("background.js")
+ .Build())
+ .Build())
+ .Build())
+ .Build())
.SetID("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb")
.Build();

Powered by Google App Engine
This is Rietveld 408576698