Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: extensions/browser/app_window/app_window_geometry_cache_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window_geometry_cache_unittest.cc
diff --git a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
index 491f614b21499204d81884ed23e201274c5bb5f8..3c664c659fe90bcad24853c2c856f12fad1d5e0b 100644
--- a/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
+++ b/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
@@ -36,8 +36,8 @@ const char kWindowId2[] = "windowid2";
// Create a very simple extension with id.
scoped_refptr<Extension> CreateExtension(const std::string& id) {
return ExtensionBuilder()
- .SetManifest(std::move(
- DictionaryBuilder().Set("name", "test").Set("version", "0.1")))
+ .SetManifest(
+ DictionaryBuilder().Set("name", "test").Set("version", "0.1").Build())
.SetID(id)
.Build();
}
@@ -163,8 +163,10 @@ std::string AppWindowGeometryCacheTest::AddExtensionWithPrefs(
browser_context()->GetPath().AppendASCII("Extensions").AppendASCII(name);
scoped_refptr<Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(
- DictionaryBuilder().Set("name", "test").Set("version", "0.1")))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "test")
+ .Set("version", "0.1")
+ .Build())
.SetPath(path)
.Build();

Powered by Google App Engine
This is Rietveld 408576698