extensions/browser/api_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « extensions/browser/api/device_permissions_prompt_unittest.cc ('k') | extensions/browser/app_window/app_window_geometry_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api_unittest.cc

diff --git a/extensions/browser/api_unittest.cc b/extensions/browser/api_unittest.cc

index f0c0f614e8f1385dced0a3384237401f08a85d86..049656316e40b8a16de1d98cd5cf5fa062601103 100644

--- a/extensions/browser/api_unittest.cc

+++ b/extensions/browser/api_unittest.cc

@@ -44,12 +44,13 @@ void ApiUnitTest::SetUp() {

content::TestBrowserThreadBundle::DEFAULT));

user_prefs::UserPrefs::Set(browser_context(), &testing_pref_service_);

- extension_ =

- ExtensionBuilder()

- .SetManifest(std::move(

- DictionaryBuilder().Set("name", "Test").Set("version", "1.0")))

- .SetLocation(Manifest::UNPACKED)

- .Build();

+ extension_ = ExtensionBuilder()

+ .SetManifest(DictionaryBuilder()

+ .Set("name", "Test")

+ .Set("version", "1.0")

+ .Build())

+ .SetLocation(Manifest::UNPACKED)

+ .Build();

}

void ApiUnitTest::CreateBackgroundPage() {