Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3366)

Unified Diff: extensions/browser/api/device_permissions_prompt_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/device_permissions_prompt_unittest.cc
diff --git a/extensions/browser/api/device_permissions_prompt_unittest.cc b/extensions/browser/api/device_permissions_prompt_unittest.cc
index 9c2d22c0d172239db66095473ab44195bf6c409c..ba6a07eaae40d14c41950795a9dcf448bff98cad 100644
--- a/extensions/browser/api/device_permissions_prompt_unittest.cc
+++ b/extensions/browser/api/device_permissions_prompt_unittest.cc
@@ -19,10 +19,11 @@ class DevicePermissionsPromptTest : public testing::Test {};
TEST_F(DevicePermissionsPromptTest, HidPromptMessages) {
scoped_refptr<Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Test Application")
- .Set("manifest_version", 2)
- .Set("version", "1.0")))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Test Application")
+ .Set("manifest_version", 2)
+ .Set("version", "1.0")
+ .Build())
.Build();
scoped_refptr<DevicePermissionsPrompt::Prompt> prompt =
@@ -47,10 +48,11 @@ TEST_F(DevicePermissionsPromptTest, HidPromptMessages) {
TEST_F(DevicePermissionsPromptTest, UsbPromptMessages) {
scoped_refptr<Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Test Application")
- .Set("manifest_version", 2)
- .Set("version", "1.0")))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Test Application")
+ .Set("manifest_version", 2)
+ .Set("version", "1.0")
+ .Build())
.Build();
scoped_refptr<DevicePermissionsPrompt::Prompt> prompt =

Powered by Google App Engine
This is Rietveld 408576698