chrome/common/extensions/permissions/permission_set_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc ('k') | chrome/common/extensions/permissions/permissions_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permission_set_unittest.cc

diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc

index 8617b5d8c8c884aadf49af9149974dce891989de..68e13b15150f11fc4315102513fa58f269d11c27 100644

--- a/chrome/common/extensions/permissions/permission_set_unittest.cc

+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc

@@ -1308,7 +1308,7 @@ testing::AssertionResult ShowsAllHostsWarning(const std::string& pattern) {

DictionaryBuilder()

.Set("name", "TLDWildCardTest")

.Set("version", "0.1.0")

- .Set("permissions", std::move(ListBuilder().Append(pattern)))

+ .Set("permissions", ListBuilder().Append(pattern).Build())

.Build())

.Build();