Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6909)

Unified Diff: chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
diff --git a/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc b/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
index ff29ab3714d0729b0a2c8d0c13e6c6e5198a2f39..fe583d9d1ef2c28c4782c3603c2106a246e3f006 100644
--- a/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
+++ b/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc
@@ -179,19 +179,20 @@ TEST_F(ChromeChannelFeatureFilterTest, SimpleFeatureAvailability) {
scoped_ptr<base::DictionaryValue> rule(
DictionaryBuilder()
.Set("feature1",
- std::move(ListBuilder()
- .Append(std::move(
- DictionaryBuilder()
- .Set("channel", "beta")
- .Set("extension_types",
- std::move(ListBuilder().Append(
- "extension")))))
- .Append(std::move(
- DictionaryBuilder()
- .Set("channel", "beta")
- .Set("extension_types",
- std::move(ListBuilder().Append(
- "legacy_packaged_app")))))))
+ ListBuilder()
+ .Append(DictionaryBuilder()
+ .Set("channel", "beta")
+ .Set("extension_types",
+ ListBuilder().Append("extension").Build())
+ .Build())
+ .Append(DictionaryBuilder()
+ .Set("channel", "beta")
+ .Set("extension_types",
+ ListBuilder()
+ .Append("legacy_packaged_app")
+ .Build())
+ .Build())
+ .Build())
.Build());
scoped_ptr<BaseFeatureProvider> provider(
@@ -243,7 +244,7 @@ TEST_F(ChromeChannelFeatureFilterTest, ComplexFeatureAvailability) {
scoped_ptr<base::DictionaryValue> rule(
DictionaryBuilder()
.Set("channel", "trunk")
- .Set("extension_types", std::move(ListBuilder().Append("extension")))
+ .Set("extension_types", ListBuilder().Append("extension").Build())
.Build());
simple_feature->Parse(rule.get());
features->push_back(std::move(simple_feature));
@@ -253,7 +254,7 @@ TEST_F(ChromeChannelFeatureFilterTest, ComplexFeatureAvailability) {
rule = DictionaryBuilder()
.Set("channel", "stable")
.Set("extension_types",
- std::move(ListBuilder().Append("legacy_packaged_app")))
+ ListBuilder().Append("legacy_packaged_app").Build())
.Build();
simple_feature->Parse(rule.get());
features->push_back(std::move(simple_feature));

Powered by Google App Engine
This is Rietveld 408576698