Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/json/json_file_value_serializer.h" 10 #include "base/json/json_file_value_serializer.h"
(...skipping 1290 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 EXPECT_TRUE(VerifyNoPermissionMessages(extension->permissions_data())); 1301 EXPECT_TRUE(VerifyNoPermissionMessages(extension->permissions_data()));
1302 } 1302 }
1303 1303
1304 testing::AssertionResult ShowsAllHostsWarning(const std::string& pattern) { 1304 testing::AssertionResult ShowsAllHostsWarning(const std::string& pattern) {
1305 scoped_refptr<Extension> extension = 1305 scoped_refptr<Extension> extension =
1306 ExtensionBuilder() 1306 ExtensionBuilder()
1307 .SetManifest( 1307 .SetManifest(
1308 DictionaryBuilder() 1308 DictionaryBuilder()
1309 .Set("name", "TLDWildCardTest") 1309 .Set("name", "TLDWildCardTest")
1310 .Set("version", "0.1.0") 1310 .Set("version", "0.1.0")
1311 .Set("permissions", std::move(ListBuilder().Append(pattern))) 1311 .Set("permissions", ListBuilder().Append(pattern).Build())
1312 .Build()) 1312 .Build())
1313 .Build(); 1313 .Build();
1314 1314
1315 return VerifyHasPermissionMessage( 1315 return VerifyHasPermissionMessage(
1316 extension->permissions_data(), 1316 extension->permissions_data(),
1317 l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS)); 1317 l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS));
1318 } 1318 }
1319 1319
1320 TEST(PermissionsTest, GetWarningMessages_TLDWildcardTreatedAsAllHosts) { 1320 TEST(PermissionsTest, GetWarningMessages_TLDWildcardTreatedAsAllHosts) {
1321 EXPECT_TRUE(ShowsAllHostsWarning("http://*.com/*")); // most popular. 1321 EXPECT_TRUE(ShowsAllHostsWarning("http://*.com/*")); // most popular.
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
1766 scoped_refptr<Extension> extension_dwr( 1766 scoped_refptr<Extension> extension_dwr(
1767 LoadManifest("permissions", "web_request_all_host_permissions.json")); 1767 LoadManifest("permissions", "web_request_all_host_permissions.json"));
1768 const PermissionSet& permissions_dwr = 1768 const PermissionSet& permissions_dwr =
1769 extension_dwr->permissions_data()->active_permissions(); 1769 extension_dwr->permissions_data()->active_permissions();
1770 1770
1771 EXPECT_FALSE(PermissionMessageProvider::Get()->IsPrivilegeIncrease( 1771 EXPECT_FALSE(PermissionMessageProvider::Get()->IsPrivilegeIncrease(
1772 permissions, permissions_dwr, extension->GetType())); 1772 permissions, permissions_dwr, extension->GetType()));
1773 } 1773 }
1774 1774
1775 } // namespace extensions 1775 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698