Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
diff --git a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
index 5b9f6fa4286d6f33eba9f43797dbae918d2a8fd6..2dd077c738718f957c7b897676c9dfd823c4590a 100644
--- a/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
+++ b/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
@@ -45,9 +45,9 @@ scoped_refptr<const extensions::Extension> CreateExtension(
Set("manifest_version", 2).
Set("version", "1.0");
if (has_browser_action)
- manifest.Set("browser_action", extensions::DictionaryBuilder());
+ manifest.Set("browser_action", extensions::DictionaryBuilder().Build());
return extensions::ExtensionBuilder()
- .SetManifest(std::move(manifest))
+ .SetManifest(manifest.Build())
.SetID(crx_file::id_util::GenerateId(name))
.Build();
}

Powered by Google App Engine
This is Rietveld 408576698