Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: chrome/browser/ui/location_bar/location_bar_browsertest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/location_bar/location_bar_browsertest.cc
diff --git a/chrome/browser/ui/location_bar/location_bar_browsertest.cc b/chrome/browser/ui/location_bar/location_bar_browsertest.cc
index 2520d72feace90a0bacdc53055fdf0b4990cf0b3..9c2ce685512334f76ec9ec70857bd6f4ab5835bc 100644
--- a/chrome/browser/ui/location_bar/location_bar_browsertest.cc
+++ b/chrome/browser/ui/location_bar/location_bar_browsertest.cc
@@ -146,18 +146,19 @@ IN_PROC_BROWSER_TEST_F(LocationBarBrowserTest,
// Create and install an extension that overrides the bookmark star.
extensions::DictionaryBuilder chrome_ui_overrides;
- chrome_ui_overrides.Set("bookmarks_ui",
- std::move(extensions::DictionaryBuilder().SetBoolean(
- "remove_button", true)));
+ chrome_ui_overrides.Set("bookmarks_ui", extensions::DictionaryBuilder()
+ .SetBoolean("remove_button", true)
+ .Build());
scoped_refptr<const extensions::Extension> extension =
extensions::ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
extensions::DictionaryBuilder()
.Set("name", "overrides star")
.Set("manifest_version", 2)
.Set("version", "0.1")
.Set("description", "override the star")
- .Set("chrome_ui_overrides", std::move(chrome_ui_overrides))))
+ .Set("chrome_ui_overrides", chrome_ui_overrides.Build())
+ .Build())
.Build();
extension_service()->AddExtension(extension.get());

Powered by Google App Engine
This is Rietveld 408576698