chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

index 5792bbf151c3c8641259282c17a071e0647e4f72..60949f3c1ebaad3f2ec15ca398a68a69b7b98914 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

@@ -1277,10 +1277,10 @@ TEST_F(ToolbarActionsModelUnitTest, ComponentExtensionsAddedToEnd) {

.Set("description", "An extension")

.Set("manifest_version", 2)

.Set("version", "1.0.0")

- .Set("browser_action", extensions::DictionaryBuilder());

+ .Set("browser_action", extensions::DictionaryBuilder().Build());

scoped_refptr<const extensions::Extension> component_extension =

extensions::ExtensionBuilder()

- .SetManifest(std::move(manifest))

+ .SetManifest(manifest.Build())

.SetID(crx_file::id_util::GenerateId(kName))

.SetLocation(extensions::Manifest::COMPONENT)

.Build();