Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6484)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm
index 3bb9fa6b8a277da7c3d4aa6ff64f008cc839e3d7..12c001853c25000b4f1b4ea6ea3f7d09f6811440 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm
@@ -79,16 +79,19 @@ class ExtensionInstalledBubbleControllerTest : public CocoaProfileTest {
manifest.Set("manifest_version", 2);
switch (type) {
case PAGE_ACTION:
- manifest.Set("page_action", DictionaryBuilder());
+ manifest.Set("page_action", DictionaryBuilder().Build());
break;
case BROWSER_ACTION:
- manifest.Set("browser_action", DictionaryBuilder());
+ manifest.Set("browser_action", DictionaryBuilder().Build());
break;
case APP:
- manifest.Set("app",
- std::move(DictionaryBuilder().Set(
- "launch", std::move(DictionaryBuilder().Set(
- "web_url", "http://www.example.com")))));
+ manifest.Set(
+ "app",
+ DictionaryBuilder()
+ .Set("launch", DictionaryBuilder()
+ .Set("web_url", "http://www.example.com")
+ .Build())
+ .Build());
break;
}
@@ -96,16 +99,17 @@ class ExtensionInstalledBubbleControllerTest : public CocoaProfileTest {
DictionaryBuilder command;
command.Set(type == PAGE_ACTION ? "_execute_page_action"
: "_execute_browser_action",
- std::move(DictionaryBuilder().Set(
- "suggested_key",
- std::move(DictionaryBuilder()
- .Set("mac", "MacCtrl+Shift+E")
- .Set("default", "Ctrl+Shift+E")))));
- manifest.Set("commands", std::move(command));
+ DictionaryBuilder()
+ .Set("suggested_key", DictionaryBuilder()
+ .Set("mac", "MacCtrl+Shift+E")
+ .Set("default", "Ctrl+Shift+E")
+ .Build())
+ .Build());
+ manifest.Set("commands", command.Build());
}
extension_ = extensions::ExtensionBuilder()
- .SetManifest(std::move(manifest))
+ .SetManifest(manifest.Build())
.SetID(crx_file::id_util::GenerateId("foo"))
.SetLocation(location)
.Build();

Powered by Google App Engine
This is Rietveld 408576698