chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/api/tabs/tabs_api_unittest.cc ('k') | chrome/browser/extensions/app_data_migrator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index 375fe6f1392760df45495a751f7325936f74b607..5f510f94fb1e016d8d824450855399d0994abac0 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -458,15 +458,18 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, HostedAppRequest) {

"/extensions/api_test/webrequest_hosted_app/index.html"));

scoped_refptr<Extension> hosted_app =

ExtensionBuilder()

- .SetManifest(std::move(

+ .SetManifest(

DictionaryBuilder()

.Set("name", "Some hosted app")

.Set("version", "1")

.Set("manifest_version", 2)

- .Set("app",

- std::move(DictionaryBuilder().Set(

- "launch", std::move(DictionaryBuilder().Set(

- "web_url", hosted_app_url.spec())))))))

+ .Set("app", DictionaryBuilder()

+ .Set("launch", DictionaryBuilder()

+ .Set("web_url",

+ hosted_app_url.spec())

+ .Build())

.Build();

ExtensionSystem::Get(browser()->profile())

->extension_service()