Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/extensions/app_data_migrator_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_data_migrator_unittest.cc
diff --git a/chrome/browser/extensions/app_data_migrator_unittest.cc b/chrome/browser/extensions/app_data_migrator_unittest.cc
index e814476700ccf173a0653a642359dfe800ddef0c..eb4b22b47e3a2e867e246f702bf0b641f273d937 100644
--- a/chrome/browser/extensions/app_data_migrator_unittest.cc
+++ b/chrome/browser/extensions/app_data_migrator_unittest.cc
@@ -75,35 +75,40 @@ class AppDataMigratorTest : public testing::Test {
scoped_refptr<const Extension> GetTestExtension(bool platform_app) {
scoped_refptr<const Extension> app;
if (platform_app) {
- app =
- ExtensionBuilder()
- .SetManifest(std::move(
- DictionaryBuilder()
- .Set("name", "test app")
- .Set("version", "1")
- .Set("app",
- std::move(DictionaryBuilder().Set(
- "background",
- std::move(DictionaryBuilder().Set(
- "scripts", std::move(ListBuilder().Append(
- "background.js")))))))
- .Set("permissions",
- std::move(ListBuilder().Append("unlimitedStorage")))))
- .Build();
+ app = ExtensionBuilder()
+ .SetManifest(
+ DictionaryBuilder()
+ .Set("name", "test app")
+ .Set("version", "1")
+ .Set("app", DictionaryBuilder()
+ .Set("background",
+ DictionaryBuilder()
+ .Set("scripts",
+ ListBuilder()
+ .Append("background.js")
+ .Build())
+ .Build())
+ .Build())
+ .Set("permissions",
+ ListBuilder().Append("unlimitedStorage").Build())
+ .Build())
+ .Build();
} else {
- app =
- ExtensionBuilder()
- .SetManifest(std::move(
- DictionaryBuilder()
- .Set("name", "test app")
- .Set("version", "1")
- .Set("app",
- std::move(DictionaryBuilder().Set(
- "launch", std::move(DictionaryBuilder().Set(
- "local_path", "index.html")))))
- .Set("permissions",
- std::move(ListBuilder().Append("unlimitedStorage")))))
- .Build();
+ app = ExtensionBuilder()
+ .SetManifest(
+ DictionaryBuilder()
+ .Set("name", "test app")
+ .Set("version", "1")
+ .Set("app", DictionaryBuilder()
+ .Set("launch",
+ DictionaryBuilder()
+ .Set("local_path", "index.html")
+ .Build())
+ .Build())
+ .Set("permissions",
+ ListBuilder().Append("unlimitedStorage").Build())
+ .Build())
+ .Build();
}
return app;
}

Powered by Google App Engine
This is Rietveld 408576698