Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5221)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api_unittest.cc b/chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
index 5396d62dd4618ec483fd9a3c6d0302888ee6ef7c..f0585a77dfeb73d6a5b88d9f0578d1fd280f2ed3 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
@@ -107,12 +107,13 @@ TEST_F(TabsApiUnitTest, QueryWithoutTabsPermission) {
// An extension with "tabs" permission however will see the third tab.
scoped_refptr<const Extension> extension_with_permission =
ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
DictionaryBuilder()
.Set("name", "Extension with tabs permission")
.Set("version", "1.0")
.Set("manifest_version", 2)
- .Set("permissions", std::move(ListBuilder().Append("tabs")))))
+ .Set("permissions", ListBuilder().Append("tabs").Build())
+ .Build())
.Build();
scoped_ptr<base::ListValue> tabs_list_with_permission(RunTabsQueryFunction(
browser(), extension_with_permission.get(), kTitleAndURLQueryInfo));
@@ -155,12 +156,13 @@ TEST_F(TabsApiUnitTest, QueryWithHostPermission) {
scoped_refptr<const Extension> extension_with_permission =
ExtensionBuilder()
.SetManifest(
- std::move(DictionaryBuilder()
- .Set("name", "Extension with tabs permission")
- .Set("version", "1.0")
- .Set("manifest_version", 2)
- .Set("permissions", std::move(ListBuilder().Append(
- "*://www.google.com/*")))))
+ DictionaryBuilder()
+ .Set("name", "Extension with tabs permission")
+ .Set("version", "1.0")
+ .Set("manifest_version", 2)
+ .Set("permissions",
+ ListBuilder().Append("*://www.google.com/*").Build())
+ .Build())
.Build();
{

Powered by Google App Engine
This is Rietveld 408576698