Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc
diff --git a/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc b/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc
index 5ca9a66bf7636cec2443468796d694edf044c141..2da72443918646fa253435169b02e7e5a7034a31 100644
--- a/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc
+++ b/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc
@@ -31,13 +31,13 @@ TEST_F(StreamsPrivateManifestTest, ValidMimeTypesHandlerMIMETypes) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()
.SetID(extension_misc::kQuickOfficeExtensionId)
- .SetManifest(std::move(
+ .SetManifest(
DictionaryBuilder()
.Set("name", "MIME type handler test")
.Set("version", "1.0.0")
.Set("manifest_version", 2)
- .Set("mime_types",
- std::move(ListBuilder().Append("text/plain")))))
+ .Set("mime_types", ListBuilder().Append("text/plain").Build())
+ .Build())
.Build();
ASSERT_TRUE(extension.get());
@@ -52,13 +52,13 @@ TEST_F(StreamsPrivateManifestTest,
MimeTypesHandlerMIMETypesNotWhitelisted) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(
+ .SetManifest(
DictionaryBuilder()
.Set("name", "MIME types test")
.Set("version", "1.0.0")
.Set("manifest_version", 2)
- .Set("mime_types",
- std::move(ListBuilder().Append("text/plain")))))
+ .Set("mime_types", ListBuilder().Append("text/plain").Build())
+ .Build())
.Build();
ASSERT_TRUE(extension.get());

Powered by Google App Engine
This is Rietveld 408576698