Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/extensions/api/storage/settings_apitest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/settings_apitest.cc
diff --git a/chrome/browser/extensions/api/storage/settings_apitest.cc b/chrome/browser/extensions/api/storage/settings_apitest.cc
index 45921cde749fc26985a059629b19c9a17d6e03f7..e909ae08f35e7ebdd02752dac9347a0e1a1a7160 100644
--- a/chrome/browser/extensions/api/storage/settings_apitest.cc
+++ b/chrome/browser/extensions/api/storage/settings_apitest.cc
@@ -499,21 +499,23 @@ IN_PROC_BROWSER_TEST_F(ExtensionSettingsApiTest, ManagedStorage) {
.Set("int-policy", -123)
.Set("double-policy", 456e7)
.SetBoolean("boolean-policy", true)
- .Set("list-policy",
- std::move(
- extensions::ListBuilder().Append("one").Append("two").Append(
- "three")))
- .Set(
- "dict-policy",
- std::move(extensions::DictionaryBuilder().Set(
- "list",
- std::move(
- extensions::ListBuilder()
- .Append(std::move(
- extensions::DictionaryBuilder().Set("one", 1).Set(
- "two", 2)))
- .Append(std::move(extensions::DictionaryBuilder().Set(
- "three", 3)))))))
+ .Set("list-policy", extensions::ListBuilder()
+ .Append("one")
+ .Append("two")
+ .Append("three")
+ .Build())
+ .Set("dict-policy",
+ extensions::DictionaryBuilder()
+ .Set("list", extensions::ListBuilder()
+ .Append(extensions::DictionaryBuilder()
+ .Set("one", 1)
+ .Set("two", 2)
+ .Build())
+ .Append(extensions::DictionaryBuilder()
+ .Set("three", 3)
+ .Build())
+ .Build())
+ .Build())
.Build();
SetPolicies(*policy);
// Now run the extension.

Powered by Google App Engine
This is Rietveld 408576698