chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/activity_log/counting_policy_unittest.cc ('k') | chrome/browser/extensions/api/debugger/debugger_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

index ead69e809b5f9fb94a9c6fa5e1a6aae1fbeeccf3..1ce3fa8bbb1dfeb5efddeec121772c8da83abacd 100644

--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

@@ -457,10 +457,11 @@ TEST_F(FullStreamUIPolicyTest, Construct) {

policy->Init();

scoped_refptr<const Extension> extension =

ExtensionBuilder()

- .SetManifest(std::move(DictionaryBuilder()

- .Set("name", "Test extension")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

+ .SetManifest(DictionaryBuilder()

+ .Set("name", "Test extension")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

.Build();

extension_service_->AddExtension(extension.get());

scoped_ptr<base::ListValue> args(new base::ListValue());

@@ -478,10 +479,11 @@ TEST_F(FullStreamUIPolicyTest, LogAndFetchActions) {

policy->Init();

scoped_refptr<const Extension> extension =

ExtensionBuilder()

- .SetManifest(std::move(DictionaryBuilder()

- .Set("name", "Test extension")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

+ .SetManifest(DictionaryBuilder()

+ .Set("name", "Test extension")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

.Build();

extension_service_->AddExtension(extension.get());

GURL gurl("http://www.google.com");

@@ -516,10 +518,11 @@ TEST_F(FullStreamUIPolicyTest, LogAndFetchFilteredActions) {

policy->Init();

scoped_refptr<const Extension> extension =

ExtensionBuilder()

- .SetManifest(std::move(DictionaryBuilder()

- .Set("name", "Test extension")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

+ .SetManifest(DictionaryBuilder()

+ .Set("name", "Test extension")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

.Build();

extension_service_->AddExtension(extension.get());

GURL gurl("http://www.google.com");

@@ -614,10 +617,11 @@ TEST_F(FullStreamUIPolicyTest, LogWithArguments) {

policy->Init();

scoped_refptr<const Extension> extension =

ExtensionBuilder()

- .SetManifest(std::move(DictionaryBuilder()

- .Set("name", "Test extension")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

+ .SetManifest(DictionaryBuilder()

+ .Set("name", "Test extension")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

.Build();

extension_service_->AddExtension(extension.get());

@@ -955,10 +959,11 @@ TEST_F(FullStreamUIPolicyTest, DeleteDatabase) {

policy->Init();

scoped_refptr<const Extension> extension =

ExtensionBuilder()

- .SetManifest(std::move(DictionaryBuilder()

- .Set("name", "Test extension")

- .Set("version", "1.0.0")

- .Set("manifest_version", 2)))

+ .SetManifest(DictionaryBuilder()

+ .Set("name", "Test extension")

+ .Set("version", "1.0.0")

+ .Set("manifest_version", 2)

+ .Build())

.Build();

extension_service_->AddExtension(extension.get());

GURL gurl("http://www.google.com");