chrome/browser/extensions/api/debugger/debugger_apitest.cc - Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_apitest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc ('K') | « chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc ('k') | chrome/browser/extensions/api/declarative_content/content_action_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/debugger/debugger_apitest.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_apitest.cc b/chrome/browser/extensions/api/debugger/debugger_apitest.cc

index 36339dbcdb349f73fb222b818fd101222010f76f..91885ec717dfbcf4c3ebf02780685df87ff84cca 100644

--- a/chrome/browser/extensions/api/debugger/debugger_apitest.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_apitest.cc

@@ -67,15 +67,16 @@ void DebuggerApiTest::SetUpCommandLine(base::CommandLine* command_line) {

void DebuggerApiTest::SetUpOnMainThread() {

ExtensionApiTest::SetUpOnMainThread();

- extension_ = ExtensionBuilder()

- .SetManifest(std::move(

- DictionaryBuilder()

- .Set("name", "debugger")

- .Set("version", "0.1")

- .Set("manifest_version", 2)

- .Set("permissions",

- std::move(ListBuilder().Append("debugger")))))

- .Build();

+ extension_ =

+ ExtensionBuilder()

+ .SetManifest(

+ DictionaryBuilder()

+ .Set("name", "debugger")

+ .Set("version", "0.1")

+ .Set("manifest_version", 2)

+ .Set("permissions", ListBuilder().Append("debugger").Build())

+ .Build())

+ .Build();

}

testing::AssertionResult DebuggerApiTest::RunAttachFunction(