Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2325)

Unified Diff: chrome/browser/extensions/activity_log/counting_policy_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/counting_policy_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
index 3d61743f855b79d28cc58c31277d6028014914c8..4eca1d996816dca65cad82be52f280445782eb2c 100644
--- a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
+++ b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
@@ -540,10 +540,11 @@ TEST_F(CountingPolicyTest, Construct) {
policy->Init();
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Test extension")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Test extension")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.Build();
extension_service_->AddExtension(extension.get());
scoped_ptr<base::ListValue> args(new base::ListValue());
@@ -561,10 +562,11 @@ TEST_F(CountingPolicyTest, LogWithStrippedArguments) {
policy->Init();
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Test extension")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Test extension")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.Build();
extension_service_->AddExtension(extension.get());
@@ -707,10 +709,11 @@ TEST_F(CountingPolicyTest, LogAndFetchFilteredActions) {
policy->Init();
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Test extension")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Test extension")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.Build();
extension_service_->AddExtension(extension.get());
GURL gurl("http://www.google.com");

Powered by Google App Engine
This is Rietveld 408576698