Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_unittest.cc
index 7267ff5ffc21566bbcd7cb6c0bdbcfdb0dca3d0f..49bcafbd760e39dd68ed6294eaa1fe8a560906c0 100644
--- a/chrome/browser/extensions/activity_log/activity_log_unittest.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_unittest.cc
@@ -236,10 +236,11 @@ TEST_F(ActivityLogTest, LogAndFetchActions) {
TEST_F(ActivityLogTest, LogPrerender) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Test extension")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Test extension")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.Build();
extension_service_->AddExtension(extension.get());
ActivityLog* activity_log = ActivityLog::GetInstance(profile());
@@ -330,10 +331,11 @@ TEST_F(ActivityLogTest, ArgUrlExtraction) {
now - base::TimeDelta::FromSeconds(3),
Action::ACTION_API_CALL,
"windows.create");
- action->set_args(ListBuilder()
- .Append(std::move(DictionaryBuilder().Set(
- "url", "http://www.google.co.uk")))
- .Build());
+ action->set_args(
+ ListBuilder()
+ .Append(
+ DictionaryBuilder().Set("url", "http://www.google.co.uk").Build())
+ .Build());
activity_log->LogAction(action);
activity_log->GetFilteredActions(
@@ -349,10 +351,11 @@ TEST_F(ActivityLogTest, ArgUrlExtraction) {
TEST_F(ActivityLogTest, UninstalledExtension) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Test extension")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Test extension")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.Build();
ActivityLog* activity_log = ActivityLog::GetInstance(profile());

Powered by Google App Engine
This is Rietveld 408576698