Make extensions::DictionaryBuilder and extensions::ListValue unmovable.

chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/values.h"
 #include "chrome/browser/extensions/activity_log/activity_action_constants.h"
 #include "chrome/browser/extensions/activity_log/activity_actions.h"
 #include "chrome/browser/extensions/activity_log/activity_log_policy.h"
@@ skipping 31 matching lines @@
 // Test that WebRequest details are stripped for privacy.
 TEST_F(ActivityLogPolicyUtilTest, StripPrivacySensitiveWebRequest) {
   scoped_refptr<Action> action = new Action(
       "punky", base::Time::Now(), Action::ACTION_WEB_REQUEST, "webRequest");
   action->mutable_other()->Set(
       activity_log_constants::kActionWebRequest,
       DictionaryBuilder()
           .Set(activity_log_web_request_constants::kNewUrlKey,
                "http://www.youtube.com/")
           .Set(activity_log_web_request_constants::kAddedRequestHeadersKey,
-               std::move(ListBuilder().Append("arg")))
-          .Build()
-          .release());

[Nico, 2016/02/27 03:33:00]

did you drop the release() intentionally?

[dcheng, 2016/02/27 03:39:30]

Yep, this method has two overloads: a scoped_ptr one and a raw pointer one. So
we may as well just use scoped_ptr.

+               ListBuilder().Append("arg").Build())
+          .Build());
 
   ActivityLogPolicy::Util::StripPrivacySensitiveFields(action);
 
   ASSERT_EQ(
       "{\"web_request\":{\"added_request_headers\":true,\"new_url\":true}}",
       ActivityLogPolicy::Util::Serialize(action->other()));
 }
 
 // Test that argument values are stripped as appropriate.
 TEST_F(ActivityLogPolicyUtilTest, StripArguments) {
@@ skipping 25 matching lines @@
       new Action("punky",
                  base::Time::Now(),
                  Action::ACTION_API_CALL,
                  "tabs.executeScript");
   action->ParsePageUrl("<incognito>http://www.google.com/");
   EXPECT_EQ("http://www.google.com/", action->page_url().spec());
   EXPECT_TRUE(action->page_incognito());
 }
 
 }  // namespace extensions