Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc

Issue 1739183003: Make extensions::DictionaryBuilder and extensions::ListValue unmovable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
index bf4482776e0f4fdafd79f02db33d97bc551f0ace..e3f9eadcaadaae8e662d116690c5e20a48886dff 100644
--- a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
@@ -149,10 +149,11 @@ TEST_F(ActivityLogEnabledTest, WatchdogSwitch) {
scoped_refptr<Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Watchdog Extension ")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Watchdog Extension ")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.SetID(kExtensionID)
.Build();
extension_service1->AddExtension(extension.get());
@@ -206,10 +207,11 @@ TEST_F(ActivityLogEnabledTest, WatchdogSwitch) {
scoped_refptr<Extension> extension2 =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Watchdog Extension ")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Watchdog Extension ")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.SetID("fpofdchlamddhnajleknffcbmnjfahpg")
.Build();
extension_service1->AddExtension(extension.get());
@@ -255,10 +257,11 @@ TEST_F(ActivityLogEnabledTest, AppAndCommandLine) {
// Enable the extension.
scoped_refptr<Extension> extension =
ExtensionBuilder()
- .SetManifest(std::move(DictionaryBuilder()
- .Set("name", "Watchdog Extension ")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)))
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "Watchdog Extension ")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Build())
.SetID(kExtensionID)
.Build();
extension_service->AddExtension(extension.get());

Powered by Google App Engine
This is Rietveld 408576698