Subzero. Moar performance tweaks.

Subzero. Moar performance tweaks.

1) Clones llvm::BitVector, and makes it Allocator aware (using the
CfgLocalAllocator<>)

2) Uses mallopt to set the malloc granularity. The default granularity
is too small, which forces too many mmap calls.

BUG=
R=sehr@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=36d6aa6545570a246a1b68d7f0ca37daea67a33a

[John, 2016-02-25 22:20:38]

jpp@chromium.org changed reviewers:
+ eholk@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-02-26 02:08:29]

lgtm

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h
File src/IceBitVector.h (right):

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h#newc...
src/IceBitVector.h:12: /// in replacement for llvm::SmallBitVector in subzero --
i.e., not all of
capitalize Subzero

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h#newc...
src/IceBitVector.h:14: ///
Also add a blurb about where BitVector comes from.

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h#newc...
src/IceBitVector.h:23: #include "llvm/Support/Compiler.h"
Can all 3 of these includes be removed?  (I'm not sure, though it does seem to
compile without them)

[sehr, 2016-02-26 03:27:40]

LGTM.

https://codereview.chromium.org/1738683003/diff/40001/src/main.cpp
File src/main.cpp (right):

https://codereview.chromium.org/1738683003/diff/40001/src/main.cpp#newcode33
src/main.cpp:33: #ifdef __pnacl__
Comment here that the pnacl implementation of malloc makes a lot of calls to
mmap and hence causes significant slowdowns.

[John, 2016-02-26 15:15:50]

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h
File src/IceBitVector.h (right):

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h#newc...
src/IceBitVector.h:12: /// in replacement for llvm::SmallBitVector in subzero --
i.e., not all of
On 2016/02/26 02:08:29, stichnot wrote:
> capitalize Subzero

Done.

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h#newc...
src/IceBitVector.h:14: ///
On 2016/02/26 02:08:29, stichnot wrote:
> Also add a blurb about where BitVector comes from.

Done.

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h#newc...
src/IceBitVector.h:23: #include "llvm/Support/Compiler.h"
On 2016/02/26 02:08:29, stichnot wrote:
> Can all 3 of these includes be removed?  (I'm not sure, though it does seem to
> compile without them)

yes, but stuff in MathExtras is used here. code should always include what it
uses to avoid dependencies on other header files, so I am leaving that one
include.

https://codereview.chromium.org/1738683003/diff/40001/src/main.cpp
File src/main.cpp (right):

https://codereview.chromium.org/1738683003/diff/40001/src/main.cpp#newcode33
src/main.cpp:33: #ifdef __pnacl__
On 2016/02/26 03:27:39, sehr wrote:
> Comment here that the pnacl implementation of malloc makes a lot of calls to
> mmap and hence causes significant slowdowns.

Done.

[Jim Stichnoth, 2016-02-26 15:18:23]

still lgtm

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h
File src/IceBitVector.h (right):

https://codereview.chromium.org/1738683003/diff/40001/src/IceBitVector.h#newc...
src/IceBitVector.h:23: #include "llvm/Support/Compiler.h"
On 2016/02/26 15:15:50, John wrote:
> On 2016/02/26 02:08:29, stichnot wrote:
> > Can all 3 of these includes be removed?  (I'm not sure, though it does seem
to
> > compile without them)
> 
> yes, but stuff in MathExtras is used here. code should always include what it
> uses to avoid dependencies on other header files, so I am leaving that one
> include.

Sounds good, thanks.

https://codereview.chromium.org/1738683003/diff/60001/src/IceBitVector.h
File src/IceBitVector.h (right):

https://codereview.chromium.org/1738683003/diff/60001/src/IceBitVector.h#newc...
src/IceBitVector.h:11: /// \brief Defines and implements a bit vector classes.
s/a //

https://codereview.chromium.org/1738683003/diff/60001/src/IceBitVector.h#newc...
src/IceBitVector.h:16: /// BitVector is a allocator aware version of
llvm::BitVector. Its
an allocator-aware

[John, 2016-02-26 15:20:03]

Description was changed from

==========
Subzero. Moar performance tweaks.

1) Clones llvm::BitVector, and makes it Allocator aware (using the
CfgLocalAllocator<>)

2) Uses mallopt to set the malloc granularity. The default granularity
is too small, which forces too many mmap calls.

BUG=
==========

to

==========
Subzero. Moar performance tweaks.

1) Clones llvm::BitVector, and makes it Allocator aware (using the
CfgLocalAllocator<>)

2) Uses mallopt to set the malloc granularity. The default granularity
is too small, which forces too many mmap calls.

BUG=
R=sehr@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2016-02-26 15:20:05]

Committed patchset #4 (id:60001) manually as
36d6aa6545570a246a1b68d7f0ca37daea67a33a (presubmit successful).