third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

index e8e0c9d69df10ffaa53ab585888595778e7afde2..e3d1b19e93327571f0a63964282addb6574f4473 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

@@ -30,8 +30,7 @@ interface DeviceOrientationEvent : Event {

readonly attribute double? alpha;

readonly attribute double? beta;

readonly attribute double? gamma;

- // TODO(philipj): absolute should not be nullable.

- readonly attribute boolean? absolute;

+ readonly attribute boolean absolute;

// TODO(philipj): The init*Event() methods are not in the spec:

// https://github.com/w3c/deviceorientation/issues/18

@@ -41,5 +40,5 @@ interface DeviceOrientationEvent : Event {

[Default=Undefined] optional double? alpha,

[Default=Undefined] optional double? beta,

[Default=Undefined] optional double? gamma,

- [Default=Undefined] optional boolean? absolute);

+ [Default=Undefined] optional boolean absolute);

};