third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl ('k') | third_party/WebKit/public/platform/modules/device_orientation/WebDeviceOrientationData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

index 0c091e036ea9fddc5d72bea229fb8b8f22d87c20..da9311664e2ca6bf54fbb617722d917f96e51138 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

@@ -53,7 +53,7 @@ void DeviceOrientationInspectorAgent::setDeviceOrientationOverride(ErrorString*

m_state->setNumber(DeviceOrientationInspectorAgentState::alpha, alpha);

m_state->setNumber(DeviceOrientationInspectorAgentState::beta, beta);

m_state->setNumber(DeviceOrientationInspectorAgentState::gamma, gamma);

- controller().setOverride(DeviceOrientationData::create(alpha, beta, gamma));

+ controller().setOverride(DeviceOrientationData::create(alpha, beta, gamma, false));

}

void DeviceOrientationInspectorAgent::clearDeviceOrientationOverride(ErrorString* error)

@@ -77,7 +77,7 @@ void DeviceOrientationInspectorAgent::restore()

m_state->getNumber(DeviceOrientationInspectorAgentState::beta, &beta);

double gamma = 0;

m_state->getNumber(DeviceOrientationInspectorAgentState::gamma, &gamma);

- controller().setOverride(DeviceOrientationData::create(alpha, beta, gamma));

+ controller().setOverride(DeviceOrientationData::create(alpha, beta, gamma, false));

}