third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.h ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

index c18d385e77de9344f31a033c9edbafe0bf42147b..4bd0770de86b8f3b40d325dbf10319153f4567ce 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp

@@ -44,7 +44,7 @@ DeviceOrientationEvent::DeviceOrientationEvent(const AtomicString& eventType, De

{

}

-void DeviceOrientationEvent::initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute)

+void DeviceOrientationEvent::initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, bool absolute)

{

if (dispatched())

return;

@@ -80,13 +80,9 @@ double DeviceOrientationEvent::gamma(bool& isNull) const

return 0;

}

-bool DeviceOrientationEvent::absolute(bool& isNull) const

+bool DeviceOrientationEvent::absolute() const

{

- if (m_orientation->canProvideAbsolute())

- return m_orientation->absolute();

- isNull = true;

- return 0;

+ return m_orientation->absolute();

}

const AtomicString& DeviceOrientationEvent::interfaceName() const