third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl - Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable

Side by Side Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl

Issue 1737443002: Make DeviceOrientationEvent.prototype.absolute non-nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.cpp ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright 2010, The Android Open Source Project	2 * Copyright 2010, The Android Open Source Project

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * * Redistributions of source code must retain the above copyright	7 * * Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * * Redistributions in binary form must reproduce the above copyright	9 * * Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 12 matching lines...) Expand all Loading...
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

24 */	24 */

25	25

26 // http://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceori entation	26 // http://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceori entation

27	27

28 // TODO(philipj): DeviceOrientationEvent should have a constructor.	28 // TODO(philipj): DeviceOrientationEvent should have a constructor.

29 interface DeviceOrientationEvent : Event {	29 interface DeviceOrientationEvent : Event {

30 readonly attribute double? alpha;	30 readonly attribute double? alpha;

31 readonly attribute double? beta;	31 readonly attribute double? beta;

32 readonly attribute double? gamma;	32 readonly attribute double? gamma;

33 // TODO(philipj): absolute should not be nullable.	33 readonly attribute boolean absolute;

34 readonly attribute boolean? absolute;

35	34

36 // TODO(philipj): The init*Event() methods are not in the spec:	35 // TODO(philipj): The init*Event() methods are not in the spec:

37 // https://github.com/w3c/deviceorientation/issues/18	36 // https://github.com/w3c/deviceorientation/issues/18

38 [Measure] void initDeviceOrientationEvent([Default=Undefined] optional DOMSt ring type,	37 [Measure] void initDeviceOrientationEvent([Default=Undefined] optional DOMSt ring type,

39 [Default=Undefined] optional boole an bubbles,	38 [Default=Undefined] optional boole an bubbles,

40 [Default=Undefined] optional boole an cancelable,	39 [Default=Undefined] optional boole an cancelable,

41 [Default=Undefined] optional doubl e? alpha,	40 [Default=Undefined] optional doubl e? alpha,

42 [Default=Undefined] optional doubl e? beta,	41 [Default=Undefined] optional doubl e? beta,

43 [Default=Undefined] optional doubl e? gamma,	42 [Default=Undefined] optional doubl e? gamma,

44 [Default=Undefined] optional boole an? absolute);	43 [Default=Undefined] optional boole an absolute);

45 };	44 };

OLD	NEW