Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1736203002: [Contextual Search] Add metrics for Resolve and View timing (Closed)

Created:
4 years, 10 months ago by Donn Denman
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Add metrics for Resolve and View timing Add metrics to record the time between starting a contextual search and the Resolve completing. Add metrics for the time between starting a contextual search and the results being viewable in the overlay. Also do some minor code cleanup: Rename some variables used for timing that had ambiguous names, remove an unused method. BUG=526291 Committed: https://crrev.com/8fe933a0ea4f518cffa061009985d814e8797b21 Cr-Commit-Position: refs/heads/master@{#378640}

Patch Set 1 #

Total comments: 16

Patch Set 2 : Updated some method names. #

Total comments: 11

Patch Set 3 : Switched to using a separate timer. #

Messages

Total messages: 27 (10 generated)
Donn Denman
Pedro, PTAL at the first three files in this CL. Thanks!
4 years, 10 months ago (2016-02-26 02:39:16 UTC) #2
pedro (no code reviews)
https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java (right): https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java#newcode389 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:389: public void onSearchResultsViewable(boolean didResolve) { Does this mean the ...
4 years, 10 months ago (2016-02-26 22:30:10 UTC) #3
Donn Denman
Thanks Pedro, PTAL. https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java (right): https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java#newcode389 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:389: public void onSearchResultsViewable(boolean didResolve) { On ...
4 years, 10 months ago (2016-02-27 00:18:40 UTC) #4
pedro (no code reviews)
lgtm https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java (right): https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java#newcode389 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:389: public void onSearchResultsViewable(boolean didResolve) { On 2016/02/27 00:18:39, ...
4 years, 10 months ago (2016-02-27 00:39:04 UTC) #5
Donn Denman
https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java File chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java (right): https://codereview.chromium.org/1736203002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java#newcode731 chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java:731: * Logs whether the promo was seen. On 2016/02/27 ...
4 years, 9 months ago (2016-02-29 17:54:11 UTC) #6
Donn Denman
Theresa, PTAL. Thanks!
4 years, 9 months ago (2016-02-29 17:54:41 UTC) #8
Donn Denman
Robert, PTAL at histograms.xml for OWNERS. Thanks!
4 years, 9 months ago (2016-02-29 17:56:46 UTC) #10
Donn Denman
4 years, 9 months ago (2016-02-29 17:59:06 UTC) #11
Theresa
https://codereview.chromium.org/1736203002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java (right): https://codereview.chromium.org/1736203002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java#newcode386 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:386: * Notifies the panel that navigation to prefetched Search ...
4 years, 9 months ago (2016-02-29 19:42:45 UTC) #12
rkaplow
lgtm histogram part lgtm
4 years, 9 months ago (2016-02-29 22:52:54 UTC) #13
Donn Denman
Theresa and/or Pedro, PTAL, this needed some rework. Theresa pointed out that I was using ...
4 years, 9 months ago (2016-03-01 21:18:08 UTC) #15
Theresa
lgtm The new timer names are great! https://codereview.chromium.org/1736203002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java File chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java (right): https://codereview.chromium.org/1736203002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java#newcode709 chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java:709: * Logs ...
4 years, 9 months ago (2016-03-01 21:48:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736203002/40001
4 years, 9 months ago (2016-03-01 21:54:04 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/189786)
4 years, 9 months ago (2016-03-01 23:22:59 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736203002/40001
4 years, 9 months ago (2016-03-02 00:25:26 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 01:08:42 UTC) #25
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 01:09:34 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8fe933a0ea4f518cffa061009985d814e8797b21
Cr-Commit-Position: refs/heads/master@{#378640}

Powered by Google App Engine
This is Rietveld 408576698