[Contextual Search] Add metrics for Resolve and View timing

chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextualsearch;
 
 import android.util.Pair;
 
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.PanelState;
@@ skipping 688 matching lines @@
         }
 
        // Also record a summary histogram with counts for each possibility.
         int code = !wasPrefetch ? NOT_PREFETCHED
                 : (durationMs == 0 ? PREFETCHED_FULLY_LOADED : PREFETCHED_PARIALLY_LOADED);
         RecordHistogram.recordEnumeratedHistogram("Search.ContextualSearchPrefetchSummary",
                 code, PREFETCH_BOUNDARY);
     }
 
     /**
+     * Logs the duration from starting a search until the Search Term is Resolved.

[Theresa, 2016/02/29 19:42:44]

Capitalization for some words is inconsistent between files. e.g. in
ContextualSearchPanelMetrics "search term" and "resolved" are lower case. I
could see an argument for "search term" being a proper noun in the Contextual
Search context, but in general English the phrase is not capitalized.

[Donn Denman, 2016/03/01 21:18:07]

Thanks for noticing this inconsistency.

I think we should leave "Search Term" and "Search Results" capitalized since
they have special meaning for us.  Lowered "resolved" here since that's just
normal English.

[Theresa, 2016/03/01 21:48:57]

sg :)

+     * @param durationMs The duration to record.
+     */
+    public static void logSearchTermResolutionDuration(long durationMs) {
+        RecordHistogram.recordMediumTimesHistogram(
+                "Search.ContextualSearchResolutionDuration", durationMs, TimeUnit.MILLISECONDS);
+    }
+
+    /**
+     * Logs the duration from starting a prefetched search until the panel navigates to the results
+     * and they start becoming viewable. Should be called only for searches that are prefetched.

[Theresa, 2016/02/29 19:42:44]

This docstring is really clear!

[Donn Denman, 2016/03/01 21:18:08]

Acknowledged.

+     * @param durationMs The duration to record.
+     * @param didResolve Whether a Search Term Resolution was required as part of the loading.
+     */
+    public static void logPrefetchedSearchNavigatedDuration(long durationMs, boolean didResolve) {
+        String histogramName = didResolve ? "Search.ContextualSearchResolvedSearchDuration"
+                                          : "Search.ContextualSearchLiteralSearchDuration";
+        RecordHistogram.recordMediumTimesHistogram(
+                histogramName, durationMs, TimeUnit.MILLISECONDS);
+    }
+
+    /**
      * Logs whether the promo was seen.
      * Logs multiple histograms, with and without the original triggering gesture.
      * @param wasPanelSeen Whether the panel was seen.
      * @param wasTap Whether the gesture that originally caused the panel to show was a Tap.
      */
     public static void logPromoSeen(boolean wasPanelSeen, boolean wasTap) {
         RecordHistogram.recordEnumeratedHistogram("Search.ContextualSearchFirstRunPanelSeen",
                 wasPanelSeen ? RESULTS_SEEN : RESULTS_NOT_SEEN, RESULTS_SEEN_BOUNDARY);
         logHistogramByGesture(wasPanelSeen, wasTap, "Search.ContextualSearchPromoSeenByGesture");
     }
@@ skipping 226 matching lines @@
      * @param wasTap Whether the gesture that originally caused the panel to show was a Tap.
      * @param histogramName The full name of the histogram to log to.
      */
     private static void logHistogramByGesture(boolean wasPanelSeen, boolean wasTap,
             String histogramName) {
         RecordHistogram.recordEnumeratedHistogram(histogramName,
                 getPanelSeenByGestureStateCode(wasPanelSeen, wasTap),
                 RESULTS_BY_GESTURE_BOUNDARY);
     }
 }