[Contextual Search] Add metrics for Resolve and View timing

chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.compositor.bottombar.contextualsearch;
 
 import android.app.Activity;
 import android.content.Context;
 import android.os.Handler;
 
@@ skipping 365 matching lines @@
     /**
      * Called when the SERP finishes loading, this records the duration of loading the SERP from
      * the time the panel was opened until the present.
      * @param wasPrefetch Whether the request was prefetch-enabled.
      */
     public void onSearchResultsLoaded(boolean wasPrefetch) {
         mPanelMetrics.onSearchResultsLoaded(wasPrefetch);
     }
 
     /**
+     * Notifies the panel that the Search Results are now viewable in the panel.
+     * @param didResolve Whether the search required Search Term Resolution.
+     */
+    public void onSearchResultsViewable(boolean didResolve) {

[pedro (no code reviews), 2016/02/26 22:30:09]

Does this mean the results were viewed, or that they simple could have been
viewed (because they were preteched)?

Assuming the latter, wouldn't it be easier to understand if this was called
onSearchResultsPrefetched()?

[Donn Denman, 2016/02/27 00:18:39]

Humm, onSearchResultsPrefetched seems confusing too because we when we just did
the prefetch loading.  How about onPrefetchedSearchNavigated?  This ties it in
with the navigation event and that it should only be called for prefetched
requests.

[pedro (no code reviews), 2016/02/27 00:39:04]

Good point. onPrefetchedSearchNavigated() seems good to me. Clearly more
intelligible than onSearchResultsViewable()

+        mPanelMetrics.onSearchResultsViewable(didResolve);
+    }
+
+    /**
      * Maximizes the Contextual Search Panel, then promotes it to a regular Tab.
      * @param reason The {@code StateChangeReason} behind the maximization and promotion to tab.
      */
     public void maximizePanelThenPromoteToTab(StateChangeReason reason) {
         mShouldPromoteToTabAfterMaximizing = true;
         maximizePanel(reason);
     }
 
     /**
      * Maximizes the Contextual Search Panel, then promotes it to a regular Tab.
@@ skipping 67 matching lines @@
     public void displaySearchContext(String selection, String end) {
         cancelSearchTermResolutionAnimation();
         getSearchBarControl().setSearchContext(selection, end);
         resetSearchBarContextOpacity();
     }
 
     /**
      * Handles showing the resolved search term in the SearchBar.
      * @param searchTerm The string that represents the search term.
      */
-    public void onSearchTermResolutionResponse(String searchTerm) {
+    public void onSearchTermResolved(String searchTerm) {
+        mPanelMetrics.onSearchTermResolved();
         getSearchBarControl().setSearchTerm(searchTerm);
         animateSearchTermResolution();
     }
 
     /**
      * Sets that the contextual search involved the promo.
      */
     public void setDidSearchInvolvePromo() {
         mPanelMetrics.setDidSearchInvolvePromo();
     }
@@ skipping 250 matching lines @@
 
     /**
      * Destroy the current content in the panel.
      * NOTE(mdjones): This should not be exposed. The only use is in ContextualSearchManager for a
      * bug related to loading new panel content.
      */
     public void destroyContent() {
         super.destroyOverlayPanelContent();
     }
 }