Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1734693003: Revert of DevTools: simplify JSONValues API, prepare to the OwnPtr migration. (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, vmpstr+blinkwatch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: simplify JSONValues API, prepare to the OwnPtr migration. (patchset #2 id:20001 of https://codereview.chromium.org/1728873002/ ) Reason for revert: Collided with https://codereview.chromium.org/1730653002 Original issue's description: > DevTools: simplify JSONValues API, prepare to the OwnPtr migration. > > Committed: https://crrev.com/43c8de64e250e814ea15c4240d5d4273a8272535 > Cr-Commit-Position: refs/heads/master@{#377409} TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/74b1089154339a81247f7d21630b7abc98980d13 Cr-Commit-Position: refs/heads/master@{#377411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -170 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/JSONParserTest.cpp View 10 chunks +14 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/JSONValues.h View 8 chunks +94 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/platform/JSONValues.cpp View 10 chunks +102 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 13 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 5 chunks +20 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 12 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
Created Revert of DevTools: simplify JSONValues API, prepare to the OwnPtr migration.
4 years, 10 months ago (2016-02-24 22:35:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734693003/1
4 years, 10 months ago (2016-02-24 22:38:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 22:42:03 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 22:43:36 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/74b1089154339a81247f7d21630b7abc98980d13
Cr-Commit-Position: refs/heads/master@{#377411}

Powered by Google App Engine
This is Rietveld 408576698