third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 1734693003: Revert of DevTools: simplify JSONValues API, prepare to the OwnPtr migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 1734693003: Revert of DevTools: simplify JSONValues API, prepare to the OwnPtr migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp ('k') | third_party/WebKit/Source/platform/JSONParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index 2050cb30cec6e5fa246fe79de0a0fbaed95c187b..5ed155488f9235d58b8be2e53aa95fb66d321366 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -183,7 +183,7 @@

{

JSONObject::iterator it = object->find(propertyName);

if (it != object->end())

- return JSONObject::cast(it->value);

+ return it->value->asObject();

RefPtr<JSONObject> result = JSONObject::create();

object->setObject(propertyName, result);

@@ -537,7 +537,7 @@

if (it == breakpoints->end())

return nullptr;

bool match = false;

- RefPtr<JSONObject> breakpointsByTarget = JSONObject::cast(it->value);

+ RefPtr<JSONObject> breakpointsByTarget = it->value->asObject();

breakpointsByTarget->getBoolean(DOMDebuggerAgentState::eventTargetAny, &match);

if (!match && targetName)

breakpointsByTarget->getBoolean(targetName->lower(), &match);