Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 173363002: Move mediastream module to oilpan transition types (Closed)

Created:
6 years, 10 months ago by keishi
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, kojih, arv+blink, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink, eric.carlson_apple.com, abarth-chromium, marja+watch_chromium.org, tommyw+watchlist_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, philipj_slow, Inactive
Visibility:
Public.

Description

Move mediastream module to oilpan MediaStreamTrack::Observer was only used for MediaStream so I removed it in order to avoid inheriting GarbageCollected twice. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174837

Patch Set 1 : WIP #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 16

Patch Set 4 : Added Finalized #

Total comments: 24

Patch Set 5 : WIP #

Total comments: 22

Patch Set 6 : #

Total comments: 22

Patch Set 7 : Fixed, rebased #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : toRefPtrWillBeMemberNativeArray #

Total comments: 40

Patch Set 11 : WIP #

Patch Set 12 : WIP #

Patch Set 13 : Fixed #

Patch Set 14 : Fixed non oilpan build #

Total comments: 7

Patch Set 15 : WIP #

Patch Set 16 : #

Total comments: 3

Patch Set 17 : Fixed RTCPeerConnection destructor #

Total comments: 10

Patch Set 18 : Fixed #

Patch Set 19 : Rebased #

Patch Set 20 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -247 lines) Patch
M Source/bindings/v8/V8Binding.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaDeviceInfo.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaDeviceInfo.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaDevicesRequest.h View 1 2 3 4 5 6 3 chunks +5 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaDevicesRequest.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStream.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 5 chunks +15 lines, -13 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 16 chunks +37 lines, -30 lines 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 5 chunks +11 lines, -15 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 8 chunks +25 lines, -18 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.idl View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackEvent.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackEvent.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.h View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackSourcesRequestImpl.cpp View 1 2 3 4 5 6 2 chunks +9 lines, -2 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/NavigatorUserMediaError.h View 1 2 3 4 5 6 1 chunk +6 lines, -4 lines 0 comments Download
M Source/modules/mediastream/NavigatorUserMediaError.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
Source/modules/mediastream/NavigatorUserMediaError.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 4 chunks +8 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 1 2 3 4 5 6 2 chunks +10 lines, -4 lines 0 comments Download
Source/modules/mediastream/RTCDTMFSender.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +7 lines, -5 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 1 2 3 4 5 6 2 chunks +9 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.h View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.idl View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidateEvent.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidateEvent.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 4 chunks +15 lines, -13 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 19 chunks +36 lines, -27 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.h View 1 2 3 4 5 2 chunks +5 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
Source/modules/mediastream/RTCStatsReport.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -4 lines 0 comments Download
Source/modules/mediastream/RTCStatsReport.cpp View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
Source/modules/mediastream/RTCStatsReport.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/RTCStatsRequestImpl.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCStatsRequestImpl.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
Source/modules/mediastream/RTCStatsResponse.h View 1 2 3 4 5 6 2 chunks +7 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCStatsResponse.cpp View 1 2 3 4 5 11 12 13 14 15 16 17 3 chunks +9 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCStatsResponse.idl View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
Source/modules/mediastream/SourceInfo.h View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
Source/modules/mediastream/SourceInfo.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
Source/modules/mediastream/SourceInfo.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/UserMediaClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/UserMediaController.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.h View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/mediastream/UserMediaRequest.cpp View 1 2 3 4 5 6 6 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebMediaStreamTrackSourcesRequest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebRTCStatsResponse.cpp View 1 2 3 4 5 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/MediaStreamCenter.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamCenter.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamTrackSourcesRequest.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -1 line 0 comments Download
M Source/platform/mediastream/RTCStatsRequest.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/RTCStatsResponseBase.h View 1 2 3 4 5 6 11 12 13 14 15 16 17 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/UserMediaClientImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/UserMediaClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebMediaDevicesRequest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebUserMediaRequest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebMediaStreamTrackSourcesRequest.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebRTCStatsResponse.h View 1 2 3 4 5 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebMediaDevicesRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebUserMediaRequest.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 60 (0 generated)
keishi
6 years, 10 months ago (2014-02-20 06:54:27 UTC) #1
sof
https://codereview.chromium.org/173363002/diff/50001/Source/modules/mediastream/MediaDeviceInfo.h File Source/modules/mediastream/MediaDeviceInfo.h (right): https://codereview.chromium.org/173363002/diff/50001/Source/modules/mediastream/MediaDeviceInfo.h#newcode55 Source/modules/mediastream/MediaDeviceInfo.h:55: typedef PersistentHeapVector<RefPtrWillBeMember<MediaDeviceInfo> > MediaDeviceInfoVector; Prefix WillBe ? https://codereview.chromium.org/173363002/diff/50001/Source/modules/mediastream/MediaDevicesRequest.h File ...
6 years, 10 months ago (2014-02-20 15:30:22 UTC) #2
keishi
https://codereview.chromium.org/173363002/diff/50001/Source/modules/mediastream/MediaDeviceInfo.h File Source/modules/mediastream/MediaDeviceInfo.h (right): https://codereview.chromium.org/173363002/diff/50001/Source/modules/mediastream/MediaDeviceInfo.h#newcode55 Source/modules/mediastream/MediaDeviceInfo.h:55: typedef PersistentHeapVector<RefPtrWillBeMember<MediaDeviceInfo> > MediaDeviceInfoVector; On 2014/02/20 15:30:23, sof wrote: ...
6 years, 10 months ago (2014-02-21 08:00:24 UTC) #3
haraken
https://codereview.chromium.org/173363002/diff/190001/LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html File LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html (right): https://codereview.chromium.org/173363002/diff/190001/LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html#newcode34 LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html:34: document.querySelector('input[type=text]').focus(); What is this change for? https://codereview.chromium.org/173363002/diff/190001/Source/bindings/v8/V8Binding.h File Source/bindings/v8/V8Binding.h ...
6 years, 10 months ago (2014-02-21 10:47:04 UTC) #4
keishi
https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h File Source/modules/mediastream/SourceInfo.h (right): https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h#newcode55 Source/modules/mediastream/SourceInfo.h:55: typedef WillBePersistentHeapVector<RefPtrWillBeMember<SourceInfo> > SourceInfoVector; On 2014/02/21 10:47:05, haraken wrote: ...
6 years, 10 months ago (2014-02-25 07:45:11 UTC) #5
tkent
https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h File Source/modules/mediastream/SourceInfo.h (right): https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h#newcode55 Source/modules/mediastream/SourceInfo.h:55: typedef WillBePersistentHeapVector<RefPtrWillBeMember<SourceInfo> > SourceInfoVector; On 2014/02/25 07:45:12, keishi1 wrote: ...
6 years, 10 months ago (2014-02-25 09:04:45 UTC) #6
Nils Barth (inactive)
Quick not LGTM to prevent build breakage: this needs to also implement the Python side ...
6 years, 10 months ago (2014-02-26 04:29:47 UTC) #7
keishi
https://codereview.chromium.org/173363002/diff/190001/LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html File LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html (right): https://codereview.chromium.org/173363002/diff/190001/LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html#newcode34 LayoutTests/fast/dom/shadow/shadowdom-for-input-appearance.html:34: document.querySelector('input[type=text]').focus(); On 2014/02/21 10:47:05, haraken wrote: > > What ...
6 years, 10 months ago (2014-02-26 06:14:58 UTC) #8
tkent
https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h File Source/modules/mediastream/SourceInfo.h (right): https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h#newcode55 Source/modules/mediastream/SourceInfo.h:55: typedef WillBePersistentHeapVector<RefPtrWillBeMember<SourceInfo> > SourceInfoVector; On 2014/02/26 06:14:59, keishi1 wrote: ...
6 years, 10 months ago (2014-02-26 06:22:00 UTC) #9
keishi
On 2014/02/26 06:22:00, tkent wrote: > https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h > File Source/modules/mediastream/SourceInfo.h (right): > > https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h#newcode55 > ...
6 years, 10 months ago (2014-02-26 06:49:11 UTC) #10
Nils Barth (inactive)
Hi Keishi, Could you please add a test case for any code generator changes? (Details ...
6 years, 10 months ago (2014-02-26 07:17:53 UTC) #11
keishi
On 2014/02/26 06:49:11, keishi1 wrote: > On 2014/02/26 06:22:00, tkent wrote: > > > https://codereview.chromium.org/173363002/diff/190001/Source/modules/mediastream/SourceInfo.h ...
6 years, 10 months ago (2014-02-26 09:48:00 UTC) #12
haraken
Overall, looks good. - Please just check that 'RefPtr<X>' is gone from the code base ...
6 years, 10 months ago (2014-02-26 13:58:36 UTC) #13
keishi
https://codereview.chromium.org/173363002/diff/320001/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/173363002/diff/320001/Source/bindings/scripts/code_generator_v8.pm#newcode5484 Source/bindings/scripts/code_generator_v8.pm:5484: return "RefPtrWillBeMember<$implClassName>"; On 2014/02/26 07:17:54, Nils Barth wrote: > ...
6 years, 10 months ago (2014-02-27 07:33:34 UTC) #14
Nils Barth (inactive)
Thanks for adding a test case and Python code! (I'll take a careful look later.) ...
6 years, 9 months ago (2014-02-27 11:20:52 UTC) #15
haraken
Almost LG! I'd like to have one more reviewer on this CL. I'm not confident ...
6 years, 9 months ago (2014-02-27 15:32:42 UTC) #16
Tommy Widenflycht
In general how safe is this patch? If there is even small change that it ...
6 years, 9 months ago (2014-02-27 15:50:02 UTC) #17
haraken
Thanks tommy! > In general how safe is this patch? If there is even small ...
6 years, 9 months ago (2014-02-27 23:41:40 UTC) #18
tkent
https://codereview.chromium.org/173363002/diff/340001/Source/platform/DEPS File Source/platform/DEPS (right): https://codereview.chromium.org/173363002/diff/340001/Source/platform/DEPS#newcode9 Source/platform/DEPS:9: "+heap", I don't want to approve this change until ...
6 years, 9 months ago (2014-02-28 00:16:29 UTC) #19
haraken
https://codereview.chromium.org/173363002/diff/340001/Source/platform/DEPS File Source/platform/DEPS (right): https://codereview.chromium.org/173363002/diff/340001/Source/platform/DEPS#newcode9 Source/platform/DEPS:9: "+heap", On 2014/02/28 00:16:30, tkent wrote: > I don't ...
6 years, 9 months ago (2014-02-28 00:22:37 UTC) #20
sof
Re: heap vector support in the IDL compiler -- the handling of variadic methods also ...
6 years, 9 months ago (2014-03-02 20:10:53 UTC) #21
Nils Barth (inactive)
Hi Keishi, Apologies for delayed review. From the CG, changes look mostly fine. Changes to ...
6 years, 9 months ago (2014-03-03 02:47:52 UTC) #22
Nils Barth (inactive)
On 2014/03/02 20:10:53, sof wrote: > Re: heap vector support in the IDL compiler -- ...
6 years, 9 months ago (2014-03-03 02:55:06 UTC) #23
sof
On 2014/03/03 02:55:06, Nils Barth wrote: .... > So if other interfaces need heap vectors, ...
6 years, 9 months ago (2014-03-05 07:35:23 UTC) #24
Nils Barth (inactive)
On 2014/03/05 07:35:23, sof wrote: > On 2014/03/03 02:55:06, Nils Barth wrote: > .... > ...
6 years, 9 months ago (2014-03-05 07:52:14 UTC) #25
sof
On 2014/03/05 07:52:14, Nils Barth wrote: > On 2014/03/05 07:35:23, sof wrote: > > On ...
6 years, 9 months ago (2014-03-06 14:29:02 UTC) #26
haraken
What's the current status of this CL? Is moving mediastream/ to oilpan blocked by something?
6 years, 9 months ago (2014-03-28 01:06:27 UTC) #27
keishi
Rebased. I get the error when I disable oilpan. How should this be handled? haraken ...
6 years, 8 months ago (2014-04-07 09:06:51 UTC) #28
haraken
On 2014/04/07 09:06:51, keishi1 wrote: > Rebased. > > I get the error when I ...
6 years, 8 months ago (2014-04-07 09:17:59 UTC) #29
sof
I didn't go through the previous feedback, so my apologies if there is overlap with ...
6 years, 8 months ago (2014-04-07 14:22:16 UTC) #30
haraken
https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/MediaDeviceInfo.h File Source/modules/mediastream/MediaDeviceInfo.h (right): https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/MediaDeviceInfo.h#newcode37 Source/modules/mediastream/MediaDeviceInfo.h:37: class MediaDeviceInfo : public RefCountedWillBeGarbageCollectedFinalized<MediaDeviceInfo> { Can this be ...
6 years, 8 months ago (2014-04-08 04:42:34 UTC) #31
haraken
This CL is huge and a bit hard to verify correctness. I'm OK with handling ...
6 years, 8 months ago (2014-04-08 04:44:30 UTC) #32
keishi
https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/MediaDeviceInfo.h File Source/modules/mediastream/MediaDeviceInfo.h (right): https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/MediaDeviceInfo.h#newcode37 Source/modules/mediastream/MediaDeviceInfo.h:37: class MediaDeviceInfo : public RefCountedWillBeGarbageCollectedFinalized<MediaDeviceInfo> { On 2014/04/07 14:22:16, ...
6 years, 8 months ago (2014-04-11 20:03:05 UTC) #33
haraken
Double-checked. LGTM. https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/MediaStreamTrack.h File Source/modules/mediastream/MediaStreamTrack.h (right): https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/MediaStreamTrack.h#newcode103 Source/modules/mediastream/MediaStreamTrack.h:103: Vector<Observer*> m_observers; On 2014/04/11 20:03:06, keishi1 wrote: ...
6 years, 8 months ago (2014-04-14 04:42:42 UTC) #34
keishi
https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h File Source/modules/mediastream/MediaStreamTrack.h (right): https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h#newcode97 Source/modules/mediastream/MediaStreamTrack.h:97: Vector<RawPtrWillBeWeakMember<MediaStream> > m_registeredMediaStreams; On 2014/04/14 04:42:43, haraken wrote: > ...
6 years, 8 months ago (2014-04-14 05:56:16 UTC) #35
haraken
https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h File Source/modules/mediastream/MediaStreamTrack.h (right): https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h#newcode97 Source/modules/mediastream/MediaStreamTrack.h:97: Vector<RawPtrWillBeWeakMember<MediaStream> > m_registeredMediaStreams; On 2014/04/14 05:56:17, keishi1 wrote: > ...
6 years, 8 months ago (2014-04-14 06:05:48 UTC) #36
haraken
On 2014/04/14 06:05:48, haraken wrote: > https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h > File Source/modules/mediastream/MediaStreamTrack.h (right): > > https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h#newcode97 > ...
6 years, 8 months ago (2014-04-14 06:06:31 UTC) #37
Erik Corry
https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h File Source/modules/mediastream/MediaStreamTrack.h (right): https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.h#newcode97 Source/modules/mediastream/MediaStreamTrack.h:97: Vector<RawPtrWillBeWeakMember<MediaStream> > m_registeredMediaStreams; On 2014/04/14 05:56:17, keishi1 wrote: > ...
6 years, 8 months ago (2014-04-14 09:10:33 UTC) #38
haraken
https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.cpp File Source/modules/mediastream/MediaStreamTrack.cpp (right): https://codereview.chromium.org/173363002/diff/500001/Source/modules/mediastream/MediaStreamTrack.cpp#newcode209 Source/modules/mediastream/MediaStreamTrack.cpp:209: size_t pos = m_registeredMediaStreams.find(mediaStream); As far as I see ...
6 years, 8 months ago (2014-04-14 09:27:55 UTC) #39
keishi
RTCPeerConnection.html is flaky and crashing locally. http://jsbin.com/rowakivu/1 The crash log is gibberish and I am ...
6 years, 8 months ago (2014-04-21 07:14:39 UTC) #40
sof
https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/RTCPeerConnection.cpp File Source/modules/mediastream/RTCPeerConnection.cpp (right): https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/RTCPeerConnection.cpp#newcode211 Source/modules/mediastream/RTCPeerConnection.cpp:211: stop(); On 2014/04/11 20:03:06, keishi1 wrote: > On 2014/04/08 ...
6 years, 8 months ago (2014-04-21 19:51:30 UTC) #41
tkent
https://codereview.chromium.org/173363002/diff/540001/Source/modules/mediastream/MediaStream.h File Source/modules/mediastream/MediaStream.h (right): https://codereview.chromium.org/173363002/diff/540001/Source/modules/mediastream/MediaStream.h#newcode43 Source/modules/mediastream/MediaStream.h:43: class MediaStream FINAL : public RefCountedWillBeRefCountedGarbageCollected<MediaStream>, public ScriptWrappable, public ...
6 years, 8 months ago (2014-04-24 04:21:48 UTC) #42
keishi
ASSERT(m_stopped) was causing the test failure so I fixed that. https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/RTCPeerConnection.cpp File Source/modules/mediastream/RTCPeerConnection.cpp (right): https://codereview.chromium.org/173363002/diff/420001/Source/modules/mediastream/RTCPeerConnection.cpp#newcode211 ...
6 years, 7 months ago (2014-05-08 04:15:42 UTC) #43
keishi
ASSERT(m_stopped) was causing the test failure so I fixed that. PTAL
6 years, 7 months ago (2014-05-08 04:15:53 UTC) #44
haraken
LGTM with comments. tommyw@: We're planning to land this CL, but would it be OK? ...
6 years, 7 months ago (2014-05-08 05:08:37 UTC) #45
zerny-chromium
https://codereview.chromium.org/173363002/diff/560001/Source/platform/mediastream/RTCStatsResponseBase.h File Source/platform/mediastream/RTCStatsResponseBase.h (right): https://codereview.chromium.org/173363002/diff/560001/Source/platform/mediastream/RTCStatsResponseBase.h#newcode41 Source/platform/mediastream/RTCStatsResponseBase.h:41: virtual void trace(Visitor*) = 0; On 2014/05/08 05:08:39, haraken ...
6 years, 7 months ago (2014-05-08 08:02:35 UTC) #46
keishi
https://codereview.chromium.org/173363002/diff/560001/Source/modules/mediastream/MediaStream.h File Source/modules/mediastream/MediaStream.h (right): https://codereview.chromium.org/173363002/diff/560001/Source/modules/mediastream/MediaStream.h#newcode87 Source/modules/mediastream/MediaStream.h:87: virtual void trace(Visitor*); On 2014/05/08 05:08:39, haraken wrote: > ...
6 years, 7 months ago (2014-05-09 01:53:53 UTC) #47
keishi
On 2014/05/08 05:08:37, haraken wrote: > LGTM with comments. > > tommyw@: We're planning to ...
6 years, 7 months ago (2014-05-22 02:01:19 UTC) #48
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 7 months ago (2014-05-27 04:12:00 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/173363002/620001
6 years, 7 months ago (2014-05-27 04:12:07 UTC) #50
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 04:12:13 UTC) #51
commit-bot: I haz the power
A disapproval has been posted by following reviewers: nbarth@chromium.org. Please make sure to get positive ...
6 years, 7 months ago (2014-05-27 04:12:14 UTC) #52
keishi
On 2014/05/27 04:12:14, I haz the power (commit-bot) wrote: > A disapproval has been posted ...
6 years, 7 months ago (2014-05-27 04:16:46 UTC) #53
Nils Barth (inactive)
On 2014/05/27 04:16:46, keishi wrote: > nbarth@ could you take a look? LGTM; previous disapproval ...
6 years, 7 months ago (2014-05-27 04:41:08 UTC) #54
keishi
On 2014/05/27 04:41:08, Nils Barth wrote: > On 2014/05/27 04:16:46, keishi wrote: > > nbarth@ ...
6 years, 7 months ago (2014-05-27 04:43:52 UTC) #55
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 7 months ago (2014-05-27 04:44:05 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/173363002/620001
6 years, 7 months ago (2014-05-27 04:44:13 UTC) #57
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 06:03:46 UTC) #58
tkent
web and public lgtm
6 years, 7 months ago (2014-05-27 06:08:37 UTC) #59
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 06:20:39 UTC) #60
Message was sent while issue was closed.
Change committed as 174837

Powered by Google App Engine
This is Rietveld 408576698