Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 181513006: IDL compiler: delete Perl compiler, remove unstable/ directory (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

IDL compiler: delete Perl compiler, remove unstable/ directory Also: * Update paths (remove one os.pardir each place) * Add blank lines, since lint is pickier now BUG=239771 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13718 lines) Patch
M Source/bindings/generated_bindings.gyp View 5 chunks +19 lines, -19 lines 0 comments Download
A + Source/bindings/scripts/blink_idl_lexer.py View 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/scripts/blink_idl_parser.py View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/bindings/scripts/code_generator_v8.pm View 1 chunk +0 lines, -6477 lines 0 comments Download
A + Source/bindings/scripts/code_generator_v8.py View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/bindings/scripts/generate_bindings.pl View 1 chunk +0 lines, -267 lines 0 comments Download
A + Source/bindings/scripts/idl_compiler.py View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/bindings/scripts/idl_definitions.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/scripts/idl_definitions_builder.py View 1 chunk +1 line, -0 lines 0 comments Download
D Source/bindings/scripts/idl_parser.pm View 1 chunk +0 lines, -2226 lines 0 comments Download
A + Source/bindings/scripts/idl_reader.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/bindings/scripts/idl_serializer.pm View 1 chunk +0 lines, -126 lines 0 comments Download
A + Source/bindings/scripts/idl_validator.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/scripts/interface_dependency_resolver.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/bindings/scripts/unstable/blink_idl_lexer.py View 1 chunk +0 lines, -90 lines 0 comments Download
D Source/bindings/scripts/unstable/blink_idl_parser.py View 1 chunk +0 lines, -425 lines 0 comments Download
D Source/bindings/scripts/unstable/code_generator_v8.py View 1 chunk +0 lines, -214 lines 0 comments Download
D Source/bindings/scripts/unstable/idl_compiler.py View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/bindings/scripts/unstable/idl_definitions.py View 1 chunk +0 lines, -441 lines 0 comments Download
D Source/bindings/scripts/unstable/idl_definitions_builder.py View 1 chunk +0 lines, -518 lines 0 comments Download
D Source/bindings/scripts/unstable/idl_reader.py View 1 chunk +0 lines, -82 lines 0 comments Download
D Source/bindings/scripts/unstable/idl_validator.py View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/bindings/scripts/unstable/interface_dependency_resolver.py View 1 chunk +0 lines, -179 lines 0 comments Download
D Source/bindings/scripts/unstable/v8_attributes.py View 1 chunk +0 lines, -398 lines 0 comments Download
D Source/bindings/scripts/unstable/v8_callback_interface.py View 1 chunk +0 lines, -141 lines 0 comments Download
D Source/bindings/scripts/unstable/v8_globals.py View 1 chunk +0 lines, -32 lines 0 comments Download
D Source/bindings/scripts/unstable/v8_interface.py View 1 chunk +0 lines, -727 lines 0 comments Download
D Source/bindings/scripts/unstable/v8_methods.py View 1 chunk +0 lines, -260 lines 0 comments Download
D Source/bindings/scripts/unstable/v8_types.py View 1 chunk +0 lines, -664 lines 0 comments Download
D Source/bindings/scripts/unstable/v8_utilities.py View 1 chunk +0 lines, -236 lines 0 comments Download
A + Source/bindings/scripts/v8_attributes.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/scripts/v8_callback_interface.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/scripts/v8_globals.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/scripts/v8_interface.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/scripts/v8_methods.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/scripts/v8_types.py View 2 chunks +2 lines, -0 lines 0 comments Download
A + Source/bindings/scripts/v8_utilities.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Nils Barth (inactive)
Last step: removes Perl, Python no longer unstable!
6 years, 9 months ago (2014-02-27 11:00:10 UTC) #1
haraken
LGTM. A historical moment!
6 years, 9 months ago (2014-02-27 11:01:20 UTC) #2
haraken
Source/bindings/scripts/code_generator_v8.pm View 1 chunk +0 lines, -6477 lines ^^^ This is really cool :)
6 years, 9 months ago (2014-02-27 11:02:31 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-02-27 11:09:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/181513006/1
6 years, 9 months ago (2014-02-27 11:09:45 UTC) #5
Nils Barth (inactive)
On 2014/02/27 11:02:31, haraken wrote: > Source/bindings/scripts/code_generator_v8.pm View 1 chunk +0 lines, -6477 > lines ...
6 years, 9 months ago (2014-02-27 11:16:00 UTC) #6
commit-bot: I haz the power
Change committed as 168029
6 years, 9 months ago (2014-02-27 14:50:39 UTC) #7
Nils Barth (inactive)
6 years, 9 months ago (2014-02-28 02:40:23 UTC) #8
Message was sent while issue was closed.
On 2014/02/27 11:02:31, haraken wrote:
> Source/bindings/scripts/code_generator_v8.pm	 View		1 chunk	+0 lines, -6477
> lines
> 
> ^^^ This is really cool :)

Don't forget the parser:
Source/bindings/scripts/idl_parser.pm	 View		1 chunk	+0 lines, -2226 lines

Powered by Google App Engine
This is Rietveld 408576698