Move mediastream module to oilpan transition types

Source/modules/mediastream/SourceInfo.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 16 matching lines @@
 #define SourceInfo_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "public/platform/WebSourceInfo.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/Vector.h"
 
 namespace WebCore {
 
-class SourceInfo : public RefCounted<SourceInfo>, public ScriptWrappable {
+class SourceInfo : public RefCountedWillBeGarbageCollectedFinalized<SourceInfo>, public ScriptWrappable {
+    DECLARE_GC_INFO;
 public:
-    static PassRefPtr<SourceInfo> create(const blink::WebSourceInfo&);
+    static PassRefPtrWillBeRawPtr<SourceInfo> create(const blink::WebSourceInfo&);
 
     String id() const;
     String kind() const;
     String label() const;
     String facing() const;
 
+    void trace(Visitor*) { }
+
 private:
     explicit SourceInfo(const blink::WebSourceInfo&);
 
     blink::WebSourceInfo m_webSourceInfo;
 };
 
-typedef Vector<RefPtr<SourceInfo> > SourceInfoVector;
+typedef WillBePersistentHeapVector<RefPtrWillBeMember<SourceInfo> > SourceInfoVector;

[haraken, 2014/02/21 10:47:05]

This is used in MediaStreamTrackSourcesRequest, which is not yet on the heap.
Probably you might want to consider moving MediaStreamTrackSourcesRequest to the
heap and change the vector to WillBeHeapVector<>.

[keishi, 2014/02/25 07:45:12]

How do I move a class in platform dir to the heap? I can't include
heap/Handle.h.

[tkent, 2014/02/25 09:04:46]

I think we may add "+heap" to platform/DEPS if heap/ThreadState.h doesn't
contain WebCore class names.

[keishi, 2014/02/26 06:14:59]

I had to add heap to the dependencies of platform.
And I'm still getting a linking error. Any idea why?

Undefined symbols for architecture i386:
  "WebCore::MediaStreamTrackSourcesRequest::s_gcInfo", referenced from:
      WebCore::GCInfoTrait<WebCore::MediaStreamTrackSourcesRequest>::get() in
libmodules.a(modules.MediaStreamTrackSourcesRequestImpl.o)
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

[tkent, 2014/02/26 06:22:01]

Adding ../heap/blink_heap.gyp:blink_heap to platform/blink_platform.gyp as a
dependency?

 
 } // namespace WebCore
 
 #endif // SourceInfo_h