Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 166333002: IDL compiler: switch build to Python compiler (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

IDL compiler: switch build to Python compiler This switches the build to Python, rather than Perl. As of Blink r-167947, Perl and Python generate identical bindings code, so we're ready to switch: https://src.chromium.org/viewvc/blink?view=rev&revision=167947 Certain in-flight CLs may cause breakage if they land: if they only change Perl (not Python). This is generally caught by run-bindings-tests in blink_presubmit, but can fail if the change lacks test cases, or if the patch set was uploaded prior to turning on Python tests in r-167838. The only 1 I can see is: Move mediastream module to oilpan https://codereview.chromium.org/173363002/ This lacks test cases, and will break the build if it lands. I've stopped this. Ref: log: code_generator_v8.pm http://src.chromium.org/viewvc/blink/trunk/Source/bindings/scripts/code_generator_v8.pm?view=log#revHEAD BUG=239771 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167983

Patch Set 1 #

Patch Set 2 : Add pre-cache #

Patch Set 3 : Comment fixes #

Patch Set 4 : Sync #

Total comments: 5

Patch Set 5 : Revised naming #

Patch Set 6 : Rename #

Patch Set 7 : .stamp naming #

Patch Set 8 : Reupload for CQ #

Patch Set 9 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -46 lines) Patch
M Source/bindings/generated_bindings.gyp View 1 2 3 4 5 6 7 chunks +49 lines, -46 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
Nils Barth (inactive)
We're ready to switch!
6 years, 10 months ago (2014-02-26 04:30:25 UTC) #1
haraken
OK, LGTM. https://codereview.chromium.org/166333002/diff/90001/Source/bindings/generated_bindings.gyp File Source/bindings/generated_bindings.gyp (right): https://codereview.chromium.org/166333002/diff/90001/Source/bindings/generated_bindings.gyp#newcode115 Source/bindings/generated_bindings.gyp:115: 'compiler_module_files': [ idl_compiler_files ? https://codereview.chromium.org/166333002/diff/90001/Source/bindings/generated_bindings.gyp#newcode240 Source/bindings/generated_bindings.gyp:240: '<(bindings_output_dir)/JINJA_CACHED', ...
6 years, 10 months ago (2014-02-26 04:40:03 UTC) #2
haraken
Frame is going to be renamed to LocalFrame shortly. You'll need to rebase the CL ...
6 years, 10 months ago (2014-02-26 04:50:53 UTC) #3
Nils Barth (inactive)
On 2014/02/26 04:50:53, haraken wrote: > Frame is going to be renamed to LocalFrame shortly. ...
6 years, 10 months ago (2014-02-26 04:52:09 UTC) #4
Nils Barth (inactive)
Naming notes, revised. https://codereview.chromium.org/166333002/diff/90001/Source/bindings/generated_bindings.gyp File Source/bindings/generated_bindings.gyp (right): https://codereview.chromium.org/166333002/diff/90001/Source/bindings/generated_bindings.gyp#newcode115 Source/bindings/generated_bindings.gyp:115: 'compiler_module_files': [ On 2014/02/26 04:40:04, haraken ...
6 years, 10 months ago (2014-02-26 06:45:45 UTC) #5
haraken
https://codereview.chromium.org/166333002/diff/90001/Source/bindings/generated_bindings.gyp File Source/bindings/generated_bindings.gyp (right): https://codereview.chromium.org/166333002/diff/90001/Source/bindings/generated_bindings.gyp#newcode240 Source/bindings/generated_bindings.gyp:240: '<(bindings_output_dir)/JINJA_CACHED', # Dummy to track dependency On 2014/02/26 06:45:45, ...
6 years, 10 months ago (2014-02-26 06:49:10 UTC) #6
Nils Barth (inactive)
On 2014/02/26 04:52:09, Nils Barth wrote: > On 2014/02/26 04:50:53, haraken wrote: > > Frame ...
6 years, 10 months ago (2014-02-26 06:52:33 UTC) #7
Nils Barth (inactive)
On 2014/02/26 06:49:10, haraken wrote: > We want to follow the naming convention of Blink ...
6 years, 10 months ago (2014-02-26 06:58:53 UTC) #8
Nils Barth (inactive)
Anyway, it's an empty file (not a content-ful file), so it's a bit special. We ...
6 years, 10 months ago (2014-02-26 07:00:46 UTC) #9
abarth-chromium
I think we use ".stamp" files for this purpose in other parts of the build. ...
6 years, 10 months ago (2014-02-26 07:02:03 UTC) #10
Nils Barth (inactive)
On 2014/02/26 07:02:03, abarth wrote: > I think we use ".stamp" files for this purpose ...
6 years, 10 months ago (2014-02-26 07:11:38 UTC) #11
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-26 07:11:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/166333002/140001
6 years, 10 months ago (2014-02-26 07:11:57 UTC) #13
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 10 months ago (2014-02-26 07:27:58 UTC) #14
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-26 11:44:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/166333002/140001
6 years, 10 months ago (2014-02-26 11:44:38 UTC) #16
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 10 months ago (2014-02-26 11:44:46 UTC) #17
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-27 01:14:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/166333002/160001
6 years, 10 months ago (2014-02-27 01:14:28 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-27 01:37:26 UTC) #20
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-27 01:37:27 UTC) #21
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-27 01:49:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/166333002/160001
6 years, 10 months ago (2014-02-27 01:49:18 UTC) #23
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 10 months ago (2014-02-27 01:49:24 UTC) #24
Nils Barth (inactive)
On 2014/02/27 01:37:27, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-27 02:04:14 UTC) #25
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-27 02:04:22 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/166333002/180001
6 years, 10 months ago (2014-02-27 02:05:32 UTC) #27
commit-bot: I haz the power
Change committed as 167983
6 years, 9 months ago (2014-02-27 04:33:48 UTC) #28
haraken
On 2014/02/27 04:33:48, I haz the power (commit-bot) wrote: > Change committed as 167983 How ...
6 years, 9 months ago (2014-02-27 04:34:39 UTC) #29
Nils Barth (inactive)
6 years, 9 months ago (2014-02-27 04:43:48 UTC) #30
Message was sent while issue was closed.
On 2014/02/27 04:34:39, haraken wrote:
> On 2014/02/27 04:33:48, I haz the power (commit-bot) wrote:
> > Change committed as 167983
> 
> How many CLs have you landed until here? :)

Probably 400?
...of which I'd estimate about 200 are actual rewrite, 100 are cleanup, and 100
are syncing.

The tracking bug has 400+ comments, most CLs:
Rewrite the IDL compiler in Python
https://code.google.com/p/chromium/issues/detail?id=239771

Powered by Google App Engine
This is Rietveld 408576698