Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1733083002:
Execute end of scope tasks in isolate's MicrotasksCompletedCallback. (Closed)
|
Created:
4 years, 9 months ago by dgozman Modified:
4 years, 9 months ago CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExecute end of scope tasks in isolate's MicrotasksCompletedCallback.
This removes additional responsibility from V8RecursionScope and Microtask
and will allow to move microtasks management to V8.
Attempt #2, previous one was reverted due to old v8 on some bots.
BUG=585949
TEST=all green
Committed: https://crrev.com/8d209d969e963c2bd874032cbc53cd3a4e622d79
Cr-Commit-Position: refs/heads/master@{#378359}
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit #
Dependent Patchsets: Messages
Total messages: 22 (10 generated)
dgozman@chromium.org changed reviewers: + adamk@chromium.org, jochen@chromium.org
Could you please take a look? V8s side: https://codereview.chromium.org/1731773005/
lgtm https://codereview.chromium.org/1733083002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/1733083002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:83: return V8RecursionScope::recursionLevel(m_isolate); won't MSVS complain about this? Probably just prefix with !!
https://codereview.chromium.org/1733083002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/1733083002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:83: return V8RecursionScope::recursionLevel(m_isolate); On 2016/02/25 12:00:29, jochen wrote: > won't MSVS complain about this? Probably just prefix with !! Done.
The CQ bit was checked by dgozman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/1733083002/#ps20001 (title: "nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733083002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. BUG=585949 TEST=all green ========== to ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. BUG=585949 TEST=all green Committed: https://crrev.com/91394c00cf9ee2f0328538a190e0417a0eb857b3 Cr-Commit-Position: refs/heads/master@{#377953} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/91394c00cf9ee2f0328538a190e0417a0eb857b3 Cr-Commit-Position: refs/heads/master@{#377953}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1745543002/ by jwd@chromium.org. The reason for reverting is: Causing compile breakage on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder bad build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/... FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/bindings/core/v8/webcore_generated.V8PerIsolateData.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=261368-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DENABLE_OILPAN=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../../third_party/WebKit/Source -Igen/blink -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/angle/include -I../../third_party/WebKit -I../../third_party/ots/include -I../../third_party/zlib -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/libwebp -I../../third_party/libxml/mac/include -I../../third_party/libxml/src/include -I../../third_party/libxslt -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/qcms/src -I../../third_party/snappy/mac -I../../third_party/snappy/src -I../../v8/include -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wglobal-constructors -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/webkit-mac-latest-rel/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/webkit-mac-latest-rel/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -include ../../third_party/WebKit/Source/build/mac/Prefix.h -c ../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp -o obj/third_party/WebKit/Source/bindings/core/v8/webcore_generated.V8PerIsolateData.o ../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp:166:16: error: no member named 'AddMicrotasksCompletedCallback' in 'v8::Isolate'; did you mean 'AddCallCompletedCallback'? isolate()->AddMicrotasksCompletedCallback(µtasksCompletedCallback); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AddCallCompletedCallback ../../v8/include/v8.h:5842:8: note: 'AddCallCompletedCallback' declared here void AddCallCompletedCallback(CallCompletedCallback callback); ^ ../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp:227:14: error: no member named 'RemoveMicrotasksCompletedCallback' in 'v8::Isolate'; did you mean 'RemoveCallCompletedCallback'? isolate->RemoveMicrotasksCompletedCallback(µtasksCompletedCallback); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ RemoveCallCompletedCallback ../../v8/include/v8.h:5850:8: note: 'RemoveCallCompletedCallback' declared here void RemoveCallCompletedCallback(CallCompletedCallback callback); ^ 2 errors generated. ninja: build stopped: subcommand failed. .
Message was sent while issue was closed.
Description was changed from ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. BUG=585949 TEST=all green Committed: https://crrev.com/91394c00cf9ee2f0328538a190e0417a0eb857b3 Cr-Commit-Position: refs/heads/master@{#377953} ========== to ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. Attempt #2, previous one was reverted due to old v8 on some bots. BUG=585949 TEST=all green ==========
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733083002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733083002/20001
Message was sent while issue was closed.
Description was changed from ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. Attempt #2, previous one was reverted due to old v8 on some bots. BUG=585949 TEST=all green ========== to ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. Attempt #2, previous one was reverted due to old v8 on some bots. BUG=585949 TEST=all green ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. Attempt #2, previous one was reverted due to old v8 on some bots. BUG=585949 TEST=all green ========== to ========== Execute end of scope tasks in isolate's MicrotasksCompletedCallback. This removes additional responsibility from V8RecursionScope and Microtask and will allow to move microtasks management to V8. Attempt #2, previous one was reverted due to old v8 on some bots. BUG=585949 TEST=all green Committed: https://crrev.com/8d209d969e963c2bd874032cbc53cd3a4e622d79 Cr-Commit-Position: refs/heads/master@{#378359} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8d209d969e963c2bd874032cbc53cd3a4e622d79 Cr-Commit-Position: refs/heads/master@{#378359} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
