third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp - Issue 1733083002: Execute end of scope tasks in isolate's MicrotasksCompletedCallback.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 1733083002: Execute end of scope tasks in isolate's MicrotasksCompletedCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/Microtask.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/inspector/ThreadDebugger.h"	5 #include "core/inspector/ThreadDebugger.h"

6	6

7 #include "bindings/core/v8/V8Binding.h"	7 #include "bindings/core/v8/V8Binding.h"

8 #include "bindings/core/v8/V8DOMException.h"	8 #include "bindings/core/v8/V8DOMException.h"

9 #include "bindings/core/v8/V8DOMTokenList.h"	9 #include "bindings/core/v8/V8DOMTokenList.h"

10 #include "bindings/core/v8/V8HTMLAllCollection.h"	10 #include "bindings/core/v8/V8HTMLAllCollection.h"

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 return String();	73 return String();

74 }	74 }

75	75

76 bool ThreadDebugger::formatAccessorsAsProperties(v8::Local<v8::Value> value)	76 bool ThreadDebugger::formatAccessorsAsProperties(v8::Local<v8::Value> value)

77 {	77 {

78 return V8DOMWrapper::isWrapper(m_isolate, value);	78 return V8DOMWrapper::isWrapper(m_isolate, value);

79 }	79 }

80	80

81 bool ThreadDebugger::hasRecursionLevel()	81 bool ThreadDebugger::hasRecursionLevel()

82 {	82 {

83 int recursionLevel = V8RecursionScope::recursionLevel(m_isolate);	83 return V8RecursionScope::recursionLevel(m_isolate);
	jochen (gone - plz use gerrit) 2016/02/25 12:00:29 won't MSVS complain about this? Probably just pref won't MSVS complain about this? Probably just prefix with !! dgozman 2016/02/25 19:26:47 Done. Show quoted text On 2016/02/25 12:00:29, jochen wrote: > won't MSVS complain about this? Probably just prefix with !! Done.
84 if (!recursionLevel)

85 return false;

86 return recursionLevel > 1 \|\| !Microtask::performingCheckpoint(m_isolate);

87 }	84 }

88	85

89 } // namespace blink	86 } // namespace blink

OLD	NEW