Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: third_party/WebKit/Source/core/dom/Microtask.cpp

Issue 1733083002: Execute end of scope tasks in isolate's MicrotasksCompletedCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "core/dom/Microtask.h" 31 #include "core/dom/Microtask.h"
32 32
33 #include "bindings/core/v8/V8PerIsolateData.h" 33 #include "bindings/core/v8/V8PerIsolateData.h"
34 #include "bindings/core/v8/V8RecursionScope.h"
35 #include "platform/ScriptForbiddenScope.h" 34 #include "platform/ScriptForbiddenScope.h"
36 #include "platform/Task.h" 35 #include "platform/Task.h"
37 #include "public/platform/WebTaskRunner.h" 36 #include "public/platform/WebTaskRunner.h"
38 #include <v8.h> 37 #include <v8.h>
39 38
40 namespace blink { 39 namespace blink {
41 40
42 void Microtask::performCheckpoint(v8::Isolate* isolate) 41 void Microtask::performCheckpoint(v8::Isolate* isolate)
43 { 42 {
44 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate); 43 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate);
45 ASSERT(isolateData); 44 ASSERT(isolateData);
46 if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpo int() || isolateData->destructionPending() || ScriptForbiddenScope::isScriptForb idden()) 45 if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpo int() || isolateData->destructionPending() || ScriptForbiddenScope::isScriptForb idden())
47 return; 46 return;
48 isolateData->setPerformingMicrotaskCheckpoint(true); 47 isolateData->setPerformingMicrotaskCheckpoint(true);
49 { 48 isolate->RunMicrotasks();
50 // Ensure that end-of-task-or-microtask actions are performed.
51 V8RecursionScope recursionScope(isolate);
52 isolate->RunMicrotasks();
53 }
54 isolateData->setPerformingMicrotaskCheckpoint(false); 49 isolateData->setPerformingMicrotaskCheckpoint(false);
55 } 50 }
56 51
57 bool Microtask::performingCheckpoint(v8::Isolate* isolate)
58 {
59 return V8PerIsolateData::from(isolate)->performingMicrotaskCheckpoint();
60 }
61
62 static void microtaskFunctionCallback(void* data) 52 static void microtaskFunctionCallback(void* data)
63 { 53 {
64 OwnPtr<WebTaskRunner::Task> task = adoptPtr(static_cast<WebTaskRunner::Task* >(data)); 54 OwnPtr<WebTaskRunner::Task> task = adoptPtr(static_cast<WebTaskRunner::Task* >(data));
65 task->run(); 55 task->run();
66 } 56 }
67 57
68 void Microtask::enqueueMicrotask(PassOwnPtr<WebTaskRunner::Task> callback) 58 void Microtask::enqueueMicrotask(PassOwnPtr<WebTaskRunner::Task> callback)
69 { 59 {
70 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 60 v8::Isolate* isolate = v8::Isolate::GetCurrent();
71 isolate->EnqueueMicrotask(&microtaskFunctionCallback, callback.leakPtr()); 61 isolate->EnqueueMicrotask(&microtaskFunctionCallback, callback.leakPtr());
72 } 62 }
73 63
74 void Microtask::enqueueMicrotask(PassOwnPtr<Closure> callback) 64 void Microtask::enqueueMicrotask(PassOwnPtr<Closure> callback)
75 { 65 {
76 enqueueMicrotask(adoptPtr(new Task(callback))); 66 enqueueMicrotask(adoptPtr(new Task(callback)));
77 } 67 }
78 68
79 } // namespace blink 69 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Microtask.h ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698