Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1727443002: Blink CompositorAnimations: Add more tests for integration with CC. (Closed)

Created:
4 years, 10 months ago by loyso (OOO)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink CompositorAnimations: Add more tests for integration with CC. WORK IN PROGRESS. The fix itself: https://codereview.chromium.org/1543143002 TODO: Add https://codereview.chromium.org/1747283004 test here. BUG=571504

Patch Set 1 #

Patch Set 2 : Fix rebasing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
A third_party/WebKit/Source/core/animation/CompositorAnimationsSimTest.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
loyso (OOO)
4 years, 10 months ago (2016-02-23 06:03:14 UTC) #2 
You added one or more #includes that violate checkdeps rules.
  third_party/WebKit/Source/core/animation/CompositorAnimationsSimTest.cpp
      Illegal include: "web/tests/sim/SimCompositor.h"
    Because of "-web" from third_party/WebKit/Source/core's include_rules. \
  third_party/WebKit/Source/core/animation/CompositorAnimationsSimTest.cpp
      Illegal include: "web/tests/sim/SimDisplayItemList.h"
    Because of "-web" from third_party/WebKit/Source/core's include_rules. \
  third_party/WebKit/Source/core/animation/CompositorAnimationsSimTest.cpp
      Illegal include: "web/tests/sim/SimRequest.h"
    Because of "-web" from third_party/WebKit/Source/core's include_rules. \
  third_party/WebKit/Source/core/animation/CompositorAnimationsSimTest.cpp
      Illegal include: "web/tests/sim/SimTest.h"
    Because of "-web" from third_party/WebKit/Source/core's include_rules.

"We should put our tests in web/ with the other
tests for big systems there. 

We hope to move much of web into core but the core/modules split made that
complicated."

Powered by Google App Engine
This is Rietveld 408576698