Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on blink::CompositorAnimationPlayer deletion.

Tests: https://codereview.chromium.org/1810833002/

BUG=590803
Committed: https://crrev.com/127acd785639f7a18603454c6bca688c815360b7
Cr-Commit-Position: refs/heads/master@{#381408}

[loyso (OOO), 2016-03-02 00:06:19]

Description was changed from

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

BUG=590803
==========

to

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::AnimationPlayer deletion.

BUG=590803
==========

[loyso (OOO), 2016-03-02 00:06:19]

loyso@chromium.org changed reviewers:
+ alancutter@chromium.org

[loyso (OOO), 2016-03-02 00:09:25]

Description was changed from

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::AnimationPlayer deletion.

BUG=590803
==========

to

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::CompositorAnimationPlayer deletion.

BUG=590803
==========

[alancutter (OOO until 2018), 2016-03-02 01:12:19]

Looks like the tests aren't happy with this change.
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

[loyso (OOO), 2016-03-16 01:17:17]

On 2016/03/02 01:12:19, alancutter wrote:
> Looks like the tests aren't happy with this change.
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
That was my intentional DCHECK to verify the hypothesis on trybots.
PTAL!

[alancutter (OOO until 2018), 2016-03-16 05:45:44]

rslgtm

[alancutter (OOO until 2018), 2016-03-16 05:45:59]

On 2016/03/16 at 05:45:44, alancutter wrote:
> rslgtm

rs lgtm.

[loyso (OOO), 2016-03-16 05:49:07]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-03-16 05:49:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1747283004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1747283004/20001

[commit-bot: I haz the power, 2016-03-16 05:54:52]

Description was changed from

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::CompositorAnimationPlayer deletion.

BUG=590803
==========

to

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::CompositorAnimationPlayer deletion.

BUG=590803
==========

[commit-bot: I haz the power, 2016-03-16 05:54:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 05:55:53]

Description was changed from

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::CompositorAnimationPlayer deletion.

BUG=590803
==========

to

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::CompositorAnimationPlayer deletion.

BUG=590803

Committed: https://crrev.com/127acd785639f7a18603454c6bca688c815360b7
Cr-Commit-Position: refs/heads/master@{#381408}
==========

[commit-bot: I haz the power, 2016-03-16 05:55:55]

Patchset 2 (id:??) landed as
https://crrev.com/127acd785639f7a18603454c6bca688c815360b7
Cr-Commit-Position: refs/heads/master@{#381408}

[loyso (OOO), 2016-03-17 00:19:47]

Description was changed from

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::CompositorAnimationPlayer deletion.

BUG=590803

Committed: https://crrev.com/127acd785639f7a18603454c6bca688c815360b7
Cr-Commit-Position: refs/heads/master@{#381408}
==========

to

==========
Blink Compositor Animations: Reset delegate in CC on Blink player deletion.

cc::AnimationPlayer is an RC object, so it may outsurvive
blink::CompositorAnimationPlayer if attached to cc::AnimationTimeline.

We must clean-up animation delegate in cc::AnimationPlayer on
blink::CompositorAnimationPlayer deletion.

Tests: https://codereview.chromium.org/1810833002/

BUG=590803

Committed: https://crrev.com/127acd785639f7a18603454c6bca688c815360b7
Cr-Commit-Position: refs/heads/master@{#381408}
==========