Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1543143002: Blink CompositorAnimations: Do not crash if no compositor animation player. (Closed)

Created:
5 years ago by loyso (OOO)
Modified:
4 years, 12 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink CompositorAnimations: Do not crash if no compositor animation player. blink::Animation can loose compositorPlayer if Animation::m_content detached via Animation::setEffect(nullptr) If KeyframeEffect::cancelAnimationOnCompositor wants to clear m_compositorAnimationIds then it shouldn't crash. Also, note the existing comment in CompositorAnimations::cancelAnimationOnCompositor (above changed lines) BUG=571504 R=dstockwell@chromium.org Committed: https://crrev.com/48abeaf3f8886a99e68722d55050547482863fb7 Cr-Commit-Position: refs/heads/master@{#367055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
loyso (OOO)
5 years ago (2015-12-23 03:23:46 UTC) #3
alancutter (OOO until 2018)
lgtm, please add a test case before landing.
5 years ago (2015-12-23 04:48:43 UTC) #8
loyso (OOO)
On 2015/12/23 04:48:43, alancutter wrote: > lgtm, please add a test case before landing. See ...
4 years, 12 months ago (2015-12-29 04:00:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543143002/1
4 years, 12 months ago (2015-12-29 04:02:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-29 05:56:33 UTC) #13
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 05:57:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48abeaf3f8886a99e68722d55050547482863fb7
Cr-Commit-Position: refs/heads/master@{#367055}

Powered by Google App Engine
This is Rietveld 408576698