Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1727333002: Revert of Add ScriptWrappable::hasPendingActivity to AudioSourceNode (Closed)

Created:
4 years, 10 months ago by hongchan
Modified:
4 years, 10 months ago
Reviewers:
haraken, sof, Raymond Toy, Yuki
CC:
Raymond Toy, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ScriptWrappable::hasPendingActivity to AudioSourceNode (patchset #6 id:120001 of https://codereview.chromium.org/1593763002/ ) Reason for revert: There is an ordering issue in the layout test. Will fix it and retry. Original issue's description: > Add ScriptWrappable to SchduledSourceNode and ScriptProcessorNode > > |onended| event in OscillatorNode, AudioBufferSourceNode and > |onaudioprocess| event in ScriptProcessor node are not fired once the JS > reference of the node goes out of local scope. > > This CL is to keep those nodes from being collected when they still has > a pending activity. This can be done by adding > ScriptWrappable.hasPendingActivity() to them. > > The change in ScriptWrappable is: > https://codereview.chromium.org/1609343002/ > > BUG=577431, 484176, 559220 > TEST=LayoutTests/webaudio/audiosource-premature-gc.html > > Committed: https://crrev.com/cfa51385f9a17df78576c607827910f91f4c6683 > Cr-Commit-Position: refs/heads/master@{#377231} TBR=rtoy@chromium.org,haraken@chromium.org,yukishiino@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577431, 484176, 559220 Committed: https://crrev.com/109c974af8f517961ee310b99b2463d12b3d0207 Cr-Commit-Position: refs/heads/master@{#377247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -90 lines) Patch
D third_party/WebKit/LayoutTests/webaudio/audiosource-premature-gc.html View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/audiosource-premature-gc-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioSourceNode.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
hongchan
Created Revert of Add ScriptWrappable::hasPendingActivity to AudioSourceNode
4 years, 10 months ago (2016-02-24 09:12:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1727333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1727333002/1
4 years, 10 months ago (2016-02-24 09:12:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 09:14:22 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/109c974af8f517961ee310b99b2463d12b3d0207 Cr-Commit-Position: refs/heads/master@{#377247}
4 years, 10 months ago (2016-02-24 09:15:23 UTC) #5
haraken
LGTM
4 years, 10 months ago (2016-02-24 09:18:26 UTC) #6
Yuki
4 years, 10 months ago (2016-02-24 10:19:50 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698