third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp - Issue 1727333002: Revert of Add ScriptWrappable::hasPendingActivity to AudioSourceNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

Issue 1727333002: Revert of Add ScriptWrappable::hasPendingActivity to AudioSourceNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h ('k') | third_party/WebKit/Source/modules/webaudio/AudioSourceNode.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

index 460eded87107012bf84d023c665254aa1fe80be3..8823d9dbdba8cc94ef11b5ff2bd0dbb5b946adf1 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp

@@ -263,17 +263,5 @@

setAttributeEventListener(EventTypeNames::ended, listener);

}

-bool AudioScheduledSourceNode::hasPendingActivity() const

- // To avoid the leak, a node should be collected regardless of its

- // playback state if the context is closed.

- if (context()->isContextClosed())

- return false;

- // If a node is scheduled or playing, do not collect the node prematurely

- // even its reference is out of scope. Then fire onended event if assigned.

- return audioScheduledSourceHandler().isPlayingOrScheduled();

} // namespace blink