Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1724783002: Re-land enable gesture events for wheel events on all platforms other that OSX. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
tdresser
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_regression_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land enable gesture events for wheel events on all platforms other that OSX. OSX has some remaining bugs to deal with overscroll for gesture events but enable it everywhere else. Original issue was reverted in https://codereview.chromium.org/1723513002 due to regressions https://crbug.com/588691, https://crbug.com/588613 and https://crbug.com/588503 The source of the issues were that gesture events were targeted incorrectly and an extra animation occurred. These were addressed in https://codereview.chromium.org/1720023002/ and https://codereview.chromium.org/1716283002/ And the rerun of the android perf trybot with the fixes looked fine in https://codereview.chromium.org/1729433003/ BUG=568183 Committed: https://crrev.com/7ae596034010a9f58bb9361cb1c3e48f8b297f36 Cr-Commit-Position: refs/heads/master@{#377083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/common/input/input_event_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
dtapuska
4 years, 10 months ago (2016-02-23 15:21:48 UTC) #3
tdresser
In the description, can you: - link to the revert - add a description of ...
4 years, 10 months ago (2016-02-23 15:28:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724783002/1
4 years, 10 months ago (2016-02-23 19:35:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 21:11:42 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7ae596034010a9f58bb9361cb1c3e48f8b297f36 Cr-Commit-Position: refs/heads/master@{#377083}
4 years, 10 months ago (2016-02-23 21:13:03 UTC) #13
dtapuska
4 years, 10 months ago (2016-02-24 13:12:24 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1729293002/ by dtapuska@chromium.org.

The reason for reverting is: Perf bot still shows a regression with android for
some reason that didn't show up in the trybot.

Reverting for now; will try to debug..

Powered by Google App Engine
This is Rietveld 408576698